Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Version tick to v0.0.1 #171

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Simple Version tick to v0.0.1 #171

merged 1 commit into from
Sep 28, 2016

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Sep 24, 2016 •
edited by iphydf
Loading

Needs body.

@GrayHatter
Copy link
Author

@iphydf @nurupo

I needed a new branch so now I have a new pull,

prempts #56

@iphydf
Copy link
Member

iphydf commented Sep 25, 2016

Run format-source.

iphydf
iphydf approved these changes Sep 25, 2016
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @nurupo's review. After that, please rebase and I'll merge it.

nurupo
nurupo approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nurupo
Copy link
Member

nurupo commented Sep 27, 2016

A side question: do we want to keep some kind of changelog?

@iphydf iphydf merged commit 51139a0 into TokTok:master Sep 28, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
@GrayHatter GrayHatter deleted the version-tick_2 branch November 19, 2016 07:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurupo nurupo nurupo approved these changes

@iphydf iphydf iphydf approved these changes

Assignees

@nurupo nurupo

@iphydf iphydf

Labels
None yet
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GrayHatter @iphydf @nurupo