Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check that both gtest and gmock exist for tests. #2637

Merged
merged 1 commit into from
Feb 3, 2024

chore: Check that both gtest and gmock exist for tests.

8b05296
Select commit
Loading
Failed to load commit list.
Merged

chore: Check that both gtest and gmock exist for tests. #2637

chore: Check that both gtest and gmock exist for tests.
8b05296
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Feb 3, 2024 in 2s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : chore: Check that both gtest and gmock exist for tests.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : chore: Check that both gtest and gmock exist for tests.

We used to assume gtest installation includes gmock, but some users may
have only gtest and not gmock.

Fixes #2636.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : We used to assume gtest installation includes gmock, but some users may have only gtest and not gmock.

Fixes #2636.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}