chore: Check that both gtest and gmock exist for tests. #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to assume gtest installation includes gmock, but some users may have only gtest and not gmock. Fixes TokTok#2636.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2637 +/- ##
==========================================
+ Coverage 73.59% 73.65% +0.05%
==========================================
Files 148 148
Lines 30419 30419
==========================================
+ Hits 22388 22406 +18
+ Misses 8031 8013 -18 ☔ View full report in Codecov by Sentry. |
robinlinden
reviewed
Feb 3, 2024
|
Oh, you beat me to it. That's pretty much the same fix I came to. |
nurupo
approved these changes
Feb 3, 2024
robinlinden
approved these changes
Feb 3, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to assume gtest installation includes gmock, but some users may have only gtest and not gmock.
Fixes #2636.
This change is