Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use target_link_libraries directly in cmake. #2499

Merged
merged 1 commit into from
Dec 26, 2023

cleanup: Use target_link_libraries directly in cmake.

00ff078
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Use target_link_libraries directly in cmake. #2499

cleanup: Use target_link_libraries directly in cmake.
00ff078
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 26, 2023 in 2s

2 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Use target_link_libraries directly in cmake.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : Instead of using target_link_modules, which does magic that we no longer need, because we only have 1 library we install, and all binaries we build link statically because they need access to internal symbols.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}