cleanup: Use target_link_libraries directly in cmake. #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
reviewed
Dec 25, 2023
Green-Sky
reviewed
Dec 25, 2023
iphydf
force-pushed
the
pkgconfig-cmake
branch
from
1e432e8
to
e3c451d
Compare
Instead of using `target_link_modules`, which does magic that we no longer need, because we only have 1 library we install, and all binaries we build link statically because they need access to internal symbols.
iphydf
force-pushed
the
pkgconfig-cmake
branch
from
e3c451d
to
00ff078
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2499 +/- ##
==========================================
+ Coverage 68.97% 69.03% +0.06%
==========================================
Files 89 89
Lines 27770 27770
==========================================
+ Hits 19153 19172 +19
+ Misses 8617 8598 -19 ☔ View full report in Codecov by Sentry. |
Green-Sky
approved these changes
Dec 26, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using target_link_modules, which does magic that we no longer need, because we only have 1 library we install, and all binaries we build link statically because they need access to internal symbols.
This change is