Skip to content

update to TileDB-2.20.0 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimitrisStaratzis merged 8 commits into from
Feb 21, 2024
Merged

update to TileDB-2.20.0 #340

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
976b178
update to TileDB-2.20.0-rc0
DimitrisStaratzis Jan 25, 2024
3025468
update to TileDB-2.20.0-rc1
DimitrisStaratzis Feb 6, 2024
b54c542
Rename `TILEDB_CORE_EXPORTS` to `tiledb_EXPORTS`.
teo-tsirpanis Feb 6, 2024
859c070
update to TileDB-2.20.0-rc2
DimitrisStaratzis Feb 12, 2024
cb8a49d
update to TileDB-2.20.0 stable
DimitrisStaratzis Feb 19, 2024
4582041
update build.gradle
DimitrisStaratzis Feb 19, 2024
fe786c4
fix sha1sums
DimitrisStaratzis Feb 19, 2024
9606ee5
update to TileDB-2.20.1
DimitrisStaratzis Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ add_library(tiledbjni SHARED
src/main/c/custom/tiledb_custom.cxx
)

target_compile_definitions(tiledbjni PRIVATE -DTILEDB_CORE_OBJECTS_EXPORTS)
target_compile_definitions(tiledbjni PRIVATE -Dtiledb_EXPORTS)
Copy link
Member

@ihnorton ihnorton Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisStaratzis do we actually need this?

@teo-tsirpanis why did this name change?

Copy link
Member

@ihnorton ihnorton Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the reason for this -D is to enable TILEDB_EXPORT in the https://github.com/TileDB-Inc/TileDB-Java/blob/master/swig/tiledb_java_extensions.h file. That file is effectively borrowing/piggybacking on the core exports.h (we could generate our own for -Java with cmake). So probably this is the ~only usage.

Copy link
Member

@teo-tsirpanis teo-tsirpanis Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The define was renamed in TileDB-Inc/TileDB#4528. I wouldn't consider it a breaking change; this is an undocumented implementation detail that no external repository should define. This is in fact the only use of this define.

target_include_directories(tiledbjni
PRIVATE
"${CMAKE_CURRENT_SOURCE_DIR}/swig"
Expand Down