update to TileDB-2.20.0 #340
Conversation
DimitrisStaratzis
force-pushed
the
dstara/update_to_tiledb_2.20
branch
from
e6fe946 to
3025468
Compare
| ) | ||
|
|
||
| target_compile_definitions(tiledbjni PRIVATE -DTILEDB_CORE_OBJECTS_EXPORTS) | ||
| target_compile_definitions(tiledbjni PRIVATE -Dtiledb_EXPORTS) |
There was a problem hiding this comment.
@DimitrisStaratzis do we actually need this?
@teo-tsirpanis why did this name change?
There was a problem hiding this comment.
AFAICT the reason for this -D is to enable TILEDB_EXPORT in the https://github.com/TileDB-Inc/TileDB-Java/blob/master/swig/tiledb_java_extensions.h file. That file is effectively borrowing/piggybacking on the core exports.h (we could generate our own for -Java with cmake). So probably this is the ~only usage.
There was a problem hiding this comment.
The define was renamed in TileDB-Inc/TileDB#4528. I wouldn't consider it a breaking change; this is an undocumented implementation detail that no external repository should define. This is in fact the only use of this define.
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
LGTM other than the cmake question.
No description provided.