Add knip #228
Merged
Add knip #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67e12ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Oct 13, 2024
| @@ -27,6 +26,7 @@ | |||
| "validate-npm-package-name": "^3.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@changesets/types": "^5.2.1", | |||
There was a problem hiding this comment.
where do we depend on this? 🤔
There was a problem hiding this comment.
manypkg/packages/cli/src/npm-tag.ts
Line 2 in 4a835ed
Andarist
reviewed
Oct 13, 2024
.changeset/rude-geckos-happen.md
Outdated
| "@manypkg/cli": minor | ||
| --- | ||
|
|
||
| Add `knip` and fix all issues raised by it. |
There was a problem hiding this comment.
Adding knip is an internal change and the users (changesets target audience) don't care about this. Don't bother documenting what changes internally but please document the user-facing changes using changesets (like for example the removal of find-up)
This was referenced Oct 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #225 (comment) - remove
enginesfrom the rootpackage.jsonand addknip. Also add CI task forknip.All published packages already have
enginesset atnode >= 14.18.0.Accidentally, this removed 4 dependencies from
@manypkg/cli, becausefind-updependency was unused.References #221