Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Streamline China Overlord and Helix Speaker Tower names with the tool tip names and/or the actual voice lines #2322

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 3, 2023

Merge with Rebase

This change fixes the French Overlord Speaker Tower name. It no longer mismatches with the name in the tool tip.

And optionally it streamlines all Overlord and Helix Speaker Tower attachment names to be consistent with the tool tip and/or voice line names.

Affects:

  • English
  • German
  • French
  • Spanish
  • Korean
  • Brazilian

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content China Affects China faction Text Is text, string, localization related labels Sep 3, 2023
@xezon xezon changed the title Fix: Text speaker tower Fix: Streamline China Overlord and Helix Speaker Tower names with the tool tip names and/or the actual voice lines Sep 3, 2023
@xezon
Copy link
Collaborator Author

xezon commented Sep 3, 2023

Documentation added. Good.

@xezon xezon merged commit d4afbf6 into main Sep 3, 2023
@xezon xezon deleted the text-speaker-tower branch September 3, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Optional Is optional content Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant