Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appropriately sized scorches to all major faction explosions #1504

Merged
merged 32 commits into from
Dec 31, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Dec 15, 2022

This change adds appropriately sized scorches to all major faction explosions.

  • All explosions drop just one scorch
  • China TNT bombs now have smaller effects than C4 bombs
  • China Nuclear Tank explosions are no longer displaced
  • Demo GLA vehicles emits different sized scorches depending on Demo Upgrade
  • Demo GLA Battle Bus now just emits one death explosion instead of 2
  • Demo GLA Battle Bus suicide damage now works

Merge with Rebase

@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Art Is art related labels Dec 15, 2022
xezon added a commit that referenced this pull request Dec 31, 2022
xezon added a commit that referenced this pull request Dec 31, 2022
xezon added a commit that referenced this pull request Dec 31, 2022
xezon added a commit that referenced this pull request Dec 31, 2022
xezon added a commit that referenced this pull request Dec 31, 2022
… GLA Scorpion Tank, Quad Cannon, Toxin Tractor, SCUD Launcher, Marauder Tank, Radar Van, Battle Bus (#1504)
@xezon xezon deleted the add-scorches branch December 31, 2022 11:28
@Stubbjax
Copy link
Collaborator

Stubbjax commented Jan 8, 2023

Most vehicle scorches now appear too large. They were fine the way they were. Listening Outposts still create two scorches via SlowDeathBehavior ModuleTag_07. There are two FX_GattlingExplosionOneFinal definitions.

And again, why was this merged without approval, consensus or even discussion? This is terrible practice and needs to stop. And how do you reasonably expect anyone to review +2,028 -332 changes? This should have been several separate PRs (like how #1425 became 16 PRs) and it should have been made clear that this alters gameplay in addition to its presentation as a visuals-only change.

@xezon
Copy link
Collaborator Author

xezon commented Jan 8, 2023

I will check Listening Outpost.

As for too large scorch, can you please show example?

@xezon
Copy link
Collaborator Author

xezon commented Jan 8, 2023

@commy2 commy2 assigned commy2 and unassigned commy2 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work
3 participants