Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work #1501

Closed
xezon opened this issue Dec 14, 2022 · 6 comments · Fixed by #1504
Closed

Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work #1501

xezon opened this issue Dec 14, 2022 · 6 comments · Fixed by #1504
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Patch104p Is specific to this project

Comments

@xezon
Copy link
Collaborator

xezon commented Dec 14, 2022

Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work. It applies no damage and no particle effects.
@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Patch104p Is specific to this project labels Dec 14, 2022
@xezon xezon changed the title Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work. Demo_GLAVehicleBattleBusDeathWeaponDummySuicide does not work Dec 14, 2022
@commy2 commy2 self-assigned this Dec 15, 2022
@commy2
Copy link
Collaborator

commy2 commented Dec 15, 2022

Probably need to reverse these changes: https://github.com/TheSuperHackers/GeneralsGamePatch/blob/main/Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini#L22432-L22450

I don't think particle beam resistance will matter if the dummy only lives one frame.

@xezon
Copy link
Collaborator Author

xezon commented Dec 15, 2022

I confirm, ActiveBody + DestroyDie makes it work.

@xezon
Copy link
Collaborator Author

xezon commented Dec 15, 2022

There is a Radar Alert event on Battle Bus suicide.

@xezon xezon mentioned this issue Dec 15, 2022
Merged
@xezon
Copy link
Collaborator Author

xezon commented Dec 16, 2022

I had to remove Demo_GLAVehicleBattleBusDeathWeaponDummy. For some reason this causes double death explosion. I do not know where the other death explosion comes from, but that fixed it.

@commy2
Copy link
Collaborator

commy2 commented Dec 16, 2022

Remove from where? The dummy is necessary for the Bus to damage enemies.

@xezon
Copy link
Collaborator Author

xezon commented Dec 16, 2022

Removed from BattleBusSlowDeathBehavior. From there it applied damage twice. Why, I do not know.

@commy2 commy2 removed their assignment Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Patch104p Is specific to this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add appropriately sized scorches to all major faction explosions TheSuperHackers/GeneralsGamePatch
2 participants
@xezon @commy2