refactor(maputil): Remove unused variables in MapUtil

[bobtista]

• Relates to fix: Replace strcpy with strlcpy for robustness #1712

Removes dead code from the calcCRC static function in MapUtil.cpp

The function declared several variables (dirName parameter, asciiFile, tempBuf, filenameBuf) that were never used. The function only needs the fname parameter to compute the CRC of a map file.

Changes:

• Removed unused dirName parameter from function signature
• Removed unused local variables: asciiFile, tempBuf, filenameBuf, length
• Removed misleading comment suggesting directory handling
• Updated call site to pass only fname
• Applied changes to both GeneralsMD and Generals versions

[Skyaero42]

loadmap() and loadUserMaps() still need attention

[bobtista]

loadmap() and loadUserMaps() still need attention

Done. Also I found one more spot with a variable that wasn't being used, cleaned it up

[Skyaero42]

Not sure if all the refactor comments are needed. I leave that up for Xezon. Otherwise this looks good.

[bobtista]

Not sure if all the refactor comments are needed. I leave that up for Xezon. Otherwise this looks good.

I agree here, it's not changing any functionality that a future dev would need to know about, I was just trying to follow contributing guidelines - I think it's better to leave out the comments

[xezon]

Is it correct that this does not use dirName? Does it work with User Maps?

[bobtista]

Yes, in the original code (main branch line 84), calcCRC declared dirName as a parameter but never used it. The function only used fname to open the file.

fname comes from getFileListInDirectory, which returns either relative (standard maps) or absolute path (user maps)

TheFileSystem->openFile() handles both eg MapCache::loadStandardMaps and MapCache::loadUserMaps