bugfix: Repairing Chinooks and Helixes no longer take off after evacuating all passengers

[Stubbjax]

This change prevents repairing Chinooks and Helixes from taking off after evacuating all passengers.

Before

The Chinook stays landed when evacuating individual passengers, but takes off when evacuating all passengers

ABORT_REPAIR.mp4

After

The Chinook stays landed when evacuating individual or all passengers

CONTINUE_REPAIR.mp4

[Stubbjax]

I set RETAIL_COMPATIBLE_CRC to zero, but the chinook still takes off on me

I typically test by inverting the local #if RETAIL_COMPATIBLE_CRC flag when viable to avoid longer recompilation and the risk of other changes interfering or the build unknowingly failing.

I performed several tests under different configurations (listed below) and can confirm all work as expected, so I suspect something is likely wrong on your end.

• Invert #if RETAIL_COMPATIBLE_CRC + VC6 release + saved game + USA Laser Chinook
• Define RETAIL_COMPATIBLE_CRC (0) + VC6 release + multiplayer game + USA Air Force Chinook
• Define RETAIL_COMPATIBLE_CRC (0) + VS2022 debug + saved game + USA Laser Chinook
• Define RETAIL_COMPATIBLE_CRC (0) + VS2022 debug + multiplayer game + China Helix

However! While testing this, I noticed a separate bug where evacuation orders given while the transport is airborne causes the ExitDelay on the HelixContain module to be ignored. Passengers evacuated while the transport is already landed correctly use the ExitDelay. I will likely need to add a supplemental condition to defer liftoff until all passengers have exited (or entered) when healing completes to prevent repeated landings for evacuation after healing completes. I shall investigate further.

[Skyaero42]

Nice improvement!

• Tested and works as described.
• Tested that the RETAIL_COMPATIBLE_CRC guard is used correctly. Normal build does not mismatch against retail.
• Also verified it works for Helix.
• The code looks good.