Skip to content

refactor: Simplify path string formatting in World Builder #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2025
Merged

refactor: Simplify path string formatting in World Builder #1759

merged 4 commits into from
Oct 31, 2025

Conversation

@bobtista
Copy link

@bobtista bobtista commented Oct 29, 2025 •
edited
Loading

Addresses feedback on PR #1712 by removing unnecessary intermediate buffer copies before converting strcpy to strlcpy.
Merge before #1712

Changes:

  • WorldBuilder files: Replace redundant strcpy+strlcat chains with single snprintf calls
  • Eliminate temporary buffers (findBuf in WHeightMapEdit) where not needed

@Skyaero42
Copy link

Skyaero42 commented Oct 29, 2025

I would have liked you to communicate about this to avoid double work.

@bobtista
Copy link
Author

bobtista commented Oct 29, 2025

I would have liked you to communicate about this to avoid double work.

That's fair. Messaging you now :)

@bobtista bobtista force-pushed the bobtista/refactor-redundant-buffer-copies branch from f947151 to 0f8ff3a Compare October 29, 2025 19:11
@bobtista bobtista force-pushed the bobtista/refactor-redundant-buffer-copies branch from 0f8ff3a to 696bcea Compare October 29, 2025 21:20
Skyaero42
Skyaero42 requested changes Oct 30, 2025
View reviewed changes
xezon
xezon reviewed Oct 30, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change title needs to be a bit more specific.

@bobtista bobtista changed the title refactor: Eliminate redundant buffer copies refactor: Eliminate redundant buffer copies in WorldBuilder path handling Oct 30, 2025
@xezon xezon changed the title refactor: Eliminate redundant buffer copies in WorldBuilder path handling refactor: Simplify path string formatting in World Builder Oct 30, 2025
xezon
xezon approved these changes Oct 30, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon requested a review from Skyaero42 October 30, 2025 18:50
@xezon xezon added the Refactor Edits the code with insignificant behavior changes, is never user facing label Oct 30, 2025
@Skyaero42 Skyaero42 mentioned this pull request Oct 31, 2025
Closed
1 task
@xezon xezon merged commit cf55e87 into TheSuperHackers:main Oct 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

@Skyaero42 Skyaero42 Skyaero42 approved these changes

Assignees

No one assigned

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobtista @Skyaero42 @xezon