refactor(network): replace manual size calculations with packed structs by bobtista · Pull Request #1675 · TheSuperHackers/GeneralsGameCode

refactor(network): replace manual size calculations with packed structs

bobtista

committed

refactor: replace C-style casts with static_cast

bobtista

committed

refactor: add getByteCount() method to NetChatCommandMsg and use it

bobtista

committed

refactor: add getByteCount() methods to more message classes and use it

bobtista

committed

refactor: move NetPacketFieldTypes to header, use const NetPacketFieldType type, and add struct constructors

bobtista

committed

testing: static asserts for all 17 cases

bobtista

committed

refactor(network): use static cast in a couple more places

bobtista

committed

refactor(network): use static cast in about 40 more places

bobtista

committed

Use UnicodeString.getByteCount() instead of manual calculation

bobtista

committed

refactor(network): Move game command size calculation logic to getByteCount method

bobtista

committed

add missing include

bobtista

committed

refactor(network): Use UnicodeString.getByteCount() in NetChatCommandMsg

bobtista

committed

refactor(network): split argument type/count size calculation into separate lines

bobtista

committed

refactor(network): move textLength from packet headers to variable data in getByteCount()

bobtista

committed

refactor(network): implement struct inheritance for getByteCount() with packed structs

bobtista

committed

refactor(network): complete struct inheritance for all command message getByteCount() functions

bobtista

committed

refactor(network): add getByteCount() to all 25 command message classes for consistent polymorphic interface

bobtista

committed

Make getByteCount() functions static for fixed-size command messages

bobtista

committed

Fix NetPacket.cpp to use static getByteCount() calls correctly

bobtista

committed

Rename getByteCount() to getPackedByteCount()

bobtista

committed

Fix static function signatures to match header declarations

bobtista

committed

Remove misleading inheritance from packed structs - make all structs standalone

bobtista

committed

Fix inconsistent naming: rename PackedNetCommandMsg to NetPacketCommand pattern

bobtista

committed

Remove middle-man functions and call getPackedByteCount() directly in switch statement

bobtista

committed

Make getPackedByteCount() a pure virtual function and eliminate switch statement

bobtista

committed

Fix build: remove override keyword

bobtista

committed

Fix abstract class instantiation by creating missing command message classes

bobtista

committed

Fix remaining NetCommandMsg instantiations in NetPacket.cpp

bobtista

committed

Add missing destructor implementations for new command message classes

bobtista

committed

Add virtual keyword to getPackedByteCount() functions

bobtista

committed

refactor(network): replicate to generals using patch method

bobtista

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(network): replace manual size calculations with packed structs#1675

refactor(network): replace manual size calculations with packed structs#1675
bobtista wants to merge 31 commits intoTheSuperHackers:mainfrom
bobtista:bobtista/packedstructpackets

Commits on Nov 11, 2025

refactor(network): replace manual size calculations with packed structs

refactor: replace C-style casts with static_cast

refactor: add getByteCount() method to NetChatCommandMsg and use it

refactor: add getByteCount() methods to more message classes and use it

refactor: move NetPacketFieldTypes to header, use const NetPacketFieldType type, and add struct constructors

testing: static asserts for all 17 cases

refactor(network): use static cast in a couple more places

refactor(network): use static cast in about 40 more places

Use UnicodeString.getByteCount() instead of manual calculation

refactor(network): Move game command size calculation logic to getByteCount method

add missing include

refactor(network): Use UnicodeString.getByteCount() in NetChatCommandMsg

refactor(network): split argument type/count size calculation into separate lines

refactor(network): move textLength from packet headers to variable data in getByteCount()

refactor(network): implement struct inheritance for getByteCount() with packed structs

refactor(network): complete struct inheritance for all command message getByteCount() functions

refactor(network): add getByteCount() to all 25 command message classes for consistent polymorphic interface

Make getByteCount() functions static for fixed-size command messages

Fix NetPacket.cpp to use static getByteCount() calls correctly

Rename getByteCount() to getPackedByteCount()

Fix static function signatures to match header declarations

Remove misleading inheritance from packed structs - make all structs standalone

Fix inconsistent naming: rename PackedNetCommandMsg to NetPacketCommand pattern

Remove middle-man functions and call getPackedByteCount() directly in switch statement

Make getPackedByteCount() a pure virtual function and eliminate switch statement

Fix build: remove override keyword

Fix abstract class instantiation by creating missing command message classes

Fix remaining NetCommandMsg instantiations in NetPacket.cpp

Add missing destructor implementations for new command message classes

Add virtual keyword to getPackedByteCount() functions

refactor(network): replicate to generals using patch method