-
Notifications
You must be signed in to change notification settings - Fork 117
feat(ui): Implement simple Latency and FPS display #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation for positioning looks overcomplicated. It needs to be simplified.
3b1cc70 to
6bf33ea
Compare
|
Positioning code simplified. |
6bf33ea to
2f8d2d6
Compare
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
2f8d2d6 to
718196b
Compare
|
Applied all suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks very promising.
718196b to
f8be888
Compare
|
Addressed all comments and rebased onto main. |
f8be888 to
3ba7b00
Compare
|
Tweaked. |
3ba7b00 to
352a25e
Compare
352a25e to
d146644
Compare
a4d64cb to
8dfbe45
Compare
8dfbe45 to
98b1454
Compare
|
Tweaked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be replicated to Generals.
|
Replicated to Generals. |
e80c8f6 to
13dd79c
Compare
13dd79c to
8cfddf6
Compare
|
I thought this could be disabled but setting all 4 values to 0 just crashes the game. 1 is the lowest value. |
|
Please create bug report. |
Looks like to crash only when |
This change implements Latency Counter (left), FPS Counter (left), and FPS Limit (left) in Generals and Zero Hour.
They are enabled by default with a size of 8 and positioned before (to the left of) SystemTime, replicating GenTool implementation.
The following options have been added:
They can be styled and repositioned by adding the relevant fields to the InGameUI.ini data file.
Example:
In a Network Game:

In Menus:

TODO