Skip to content

feat(options): Implement user options for Screen Edge Scrolling #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2025
Merged

feat(options): Implement user options for Screen Edge Scrolling #1538

merged 5 commits into from
Sep 10, 2025

Conversation

@xezon
Copy link

@xezon xezon commented Sep 4, 2025 •
edited
Loading

This change implements user options to control the screen edge scrolling behavior.

The Options.ini gets 2 new settings with defaults that match the original behavior:

ScreenEdgeScrollEnabledInWindowedApp = no
ScreenEdgeScrollEnabledInFullscreenApp = yes

TODO

  • Replicate to Generals

@xezon xezon added this to the Important features milestone Sep 4, 2025
@xezon xezon added Enhancement Is new feature or request Major Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Sep 4, 2025
@xezon
Copy link
Author

xezon commented Sep 5, 2025 •
edited
Loading

I think better options would be:

ScreenEdgeScrollEnabledInWindowedApp = no
ScreenEdgeScrollEnabledInFullscreenApp = yes

This would make them exclusive and not dependent on each other.

Edit: Updated.

@xezon xezon changed the title feat(options): Implement user options to control the screen edge scrolling behavior feat(options): Implement user options for Screen Edge Scrolling Sep 5, 2025
@xezon xezon force-pushed the xezon/impl-edgescroll-user-options branch from 1a227e3 to 0a28e8c Compare September 5, 2025 12:31
Mauller
Mauller reviewed Sep 9, 2025
View reviewed changes
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp Outdated
Copy link

@Mauller Mauller Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to cast this to bool otherwise the compilers going to complain.

Copy link
Author

@xezon xezon Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it causes warning. Fixed.

Mauller
Mauller approved these changes Sep 9, 2025
View reviewed changes
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon force-pushed the xezon/impl-edgescroll-user-options branch from 0a28e8c to 5a8dc95 Compare September 10, 2025 10:17
@xezon
Copy link
Author

xezon commented Sep 10, 2025

Replicated to Generals with mini conflict.

Improved code comments a bit.

@xezon xezon merged commit 36b5277 into TheSuperHackers:main Sep 10, 2025
18 checks passed
@xezon xezon deleted the xezon/impl-edgescroll-user-options branch September 10, 2025 10:30
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@xezon
feat(options): Implement user options for Screen Edge Scrolling (TheS…
4427191 
…uperHackers#1538)

Adds new options ScreenEdgeScrollEnabledInWindowedApp=no, ScreenEdgeScrollEnabledInFullscreenApp=yes to Options.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mauller Mauller Mauller approved these changes

Assignees

No one assigned

Labels

Enhancement Is new feature or request Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Milestone

Important features

Development

Successfully merging this pull request may close these issues.

Revisit edge scrolling in windowed mode

2 participants

@xezon @Mauller