-
Notifications
You must be signed in to change notification settings - Fork 117
feat(controlbar): Implement full viewport support for 'Control Bar Pro' Addons #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controlbar): Implement full viewport support for 'Control Bar Pro' Addons #1412
Conversation
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, tweaks things in the places i expected them to get changed from my own experience adding support for the pro bar in my test builds.
|
Replicated in Generals with mini conflict |
| { | ||
| { | ||
| // TheSuperHackers @feature xezon 03/08/2025 Force full viewport for 'Control Bar Pro' Addons like GenTool did it. | ||
| File* file = TheFileSystem->openFile("GenTool/fullviewport.dat", File::READ | File::BINARY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does control bar pro put this file into a gentool folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It is inside one of the .big archives.
This change implements the fullviewport support for 'Control Bar Pro' Addons like GenTool did.
New command line argument is "-forcefullviewport"
GameData.ini setting is ViewportHeightScale=0..1
And file at "GenTool/fullviewport.dat" is read too for the Addon to control the behaviour.
TODO