fix(options): Fix System Time and Game Time settings not loading and applying correctly #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
added
Minor
Caball009
reviewed
Jul 23, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
xezon
reviewed
Jul 23, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
|
Unclear what "OSD" means. Prefer not using acronyms. |
|
OSD = On Screen Display |
Mauller
force-pushed
the
fixup-timers-settings
branch
from
0607b78 to
f099eba
Compare
|
This should be good to go now. |
Mauller
changed the title
xezon
approved these changes
Jul 26, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Show resolved
Hide resolved
xezon
changed the title
xezon
changed the title
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small fixup pr in which the value zero was not being considered when saving the game and sytem time font sizes in the game options.
Zero is used to disabled the game time and will eventually be input by the user through the options menu.