[ZH] Fix broken money deposit and withdraw audio and academy income record #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if there is a similar issue for the hackers money making sound, as that does not play in zero hour either compared to generals |
2 tasks
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ecord (TheSuperHackers#1311) Money deposits and withdrawals now trigger a beep sound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken money deposit and withdraw audio and academy income record.
The issue is caused by copying the Money class after the Money player index was already set. It is Zero Hour specific, because Generals does deposit the money correctly.
An alternative/supplementary fix here would be to exclude
Money::m_playerIndexfrom copying in the Money class. I am not 100% sure if that meets expectations for Money.I noticed this Money issue when testing the "Free Build" debug command.