-
Notifications
You must be signed in to change notification settings - Fork 118
[GEN][ZH] Double scroll amount for RMB, edge and keyboard scrolling #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN][ZH] Double scroll amount for RMB, edge and keyboard scrolling #1288
Conversation
|
I will tweak this after #1244 has been merged to take the new |
3d1467d to
7ea2d4a
Compare
|
Quick tweaked push with the RMB changes that were originally in the RMB scroll fixes PR. Still need to add the tweaks for keyboard and edge scrolling. |
7ea2d4a to
dfe463e
Compare
|
Updated with the scroll multiplier affecting key and edge scrolling. This should be good now, the key scrolling feels better now relative to the RMB scrolling. |
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this description is not yet complete and concise. It ideally explains why and how multiplier 2 was chosen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly easy to do in a few words, to get a better description i had to make it significantly longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is duplicate information in these sentences and I think it can be described better. I can try to write a description if you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be more concise now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pass on comments. Check if ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks good to me.
dfe463e to
0a45019
Compare
|
This should be good to go now. |
0a45019 to
00a6b23
Compare
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp
Outdated
Show resolved
Hide resolved
00a6b23 to
96204fe
Compare
96204fe to
4b0aa83
Compare
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good.
Scroll speed range seems decent. Player might be happy with it.
This PR is a small followup to the prior viewport scrolling fixes.
This PR doubles the scroll amount used by the right mouse button, keyboard and edge scrolling to allow a higher top end and faster default speed.
This also has the effect of rescaling the RMB scrolling so that the default scroll speed of 50 results in the RMB scrolling working as it did in retail at 30FPS.