Skip to content

Conversation

@Mauller
Copy link

@Mauller Mauller commented Jul 15, 2025

This PR is a small followup to the prior viewport scrolling fixes.

This PR doubles the scroll amount used by the right mouse button, keyboard and edge scrolling to allow a higher top end and faster default speed.

This also has the effect of rescaling the RMB scrolling so that the default scroll speed of 50 results in the RMB scrolling working as it did in retail at 30FPS.

@Mauller Mauller self-assigned this Jul 15, 2025
@Mauller Mauller added Enhancement Is new feature or request Gen Relates to Generals ZH Relates to Zero Hour labels Jul 15, 2025
@Mauller Mauller added this to the Important features milestone Jul 15, 2025
@Mauller Mauller added the Minor Severity: Minor < Major < Critical < Blocker label Jul 15, 2025
@Mauller
Copy link
Author

Mauller commented Jul 16, 2025

I will tweak this after #1244 has been merged to take the new SCROLL_MULTIPLIER into account instead of directly increasing the value etc.

@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from 3d1467d to 7ea2d4a Compare July 16, 2025 21:19
@Mauller Mauller changed the title [GEN][ZH] Double scroll amount for edge and keyboard scrolling [GEN][ZH] Double scroll amount for RMB, edge and keyboard scrolling Jul 16, 2025
@Mauller
Copy link
Author

Mauller commented Jul 16, 2025

Quick tweaked push with the RMB changes that were originally in the RMB scroll fixes PR.

Still need to add the tweaks for keyboard and edge scrolling.

@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from 7ea2d4a to dfe463e Compare July 19, 2025 08:21
@Mauller
Copy link
Author

Mauller commented Jul 19, 2025

Updated with the scroll multiplier affecting key and edge scrolling. This should be good now, the key scrolling feels better now relative to the RMB scrolling.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description is not yet complete and concise. It ideally explains why and how multiplier 2 was chosen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly easy to do in a few words, to get a better description i had to make it significantly longer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is duplicate information in these sentences and I think it can be described better. I can try to write a description if you need.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be more concise now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a pass on comments. Check if ok.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me.

@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from dfe463e to 0a45019 Compare July 20, 2025 08:52
@Mauller
Copy link
Author

Mauller commented Jul 20, 2025

This should be good to go now.

@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from 0a45019 to 00a6b23 Compare July 20, 2025 08:55
@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from 00a6b23 to 96204fe Compare July 20, 2025 09:36
@Mauller Mauller force-pushed the feature-faster-scroll-amt branch from 96204fe to 4b0aa83 Compare July 20, 2025 09:37
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.

Scroll speed range seems decent. Player might be happy with it.

@xezon xezon merged commit fbd4468 into TheSuperHackers:main Jul 20, 2025
14 checks passed
@xezon xezon deleted the feature-faster-scroll-amt branch July 20, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants