forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 119
Closed
Closed
Copy link
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerThisProjectThe issue was introduced by this project, or this task is specific to this projectThe issue was introduced by this project, or this task is specific to this project
Description
Since #1068 was merged, a false debug error appears during game cleanup in VS22 and in Debug mode:
It's because TheGlobalData is allocated much earlier now (probably earlier than the DebugMemoryTracker) and during deallocation it complains (probably because the memory debugger doesn't know about the allocation).
I think we can fix this by changing GlobalData.cpp:
GlobalData* GlobalData::m_theOriginal = NULL;
into
GlobalData GlobalData::m_theOriginal;
and use that as storage for the first GlobalData instance.
Metadata
Metadata
Assignees
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerThisProjectThe issue was introduced by this project, or this task is specific to this projectThe issue was introduced by this project, or this task is specific to this project
