local_weighted_learning.py: fix mypy errors and more
#8073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
awaiting reviews
14 tasks
|
@cclauss does this look good to merge? |
Rename n to m, as n tends to be used for the number of parameters rather than the sample size
The plot_preds function plots the data but doesn't actually return anything
Rename n to m, as n tends to be used for the number of parameters rather than the sample size
The plot_preds function plots the data but doesn't actually return anything
Rename n to m, as n tends to be used for the number of parameters rather than the sample size
The plot_preds function plots the data but doesn't actually return anything
Rename n to m, as n tends to be used for the number of parameters rather than the sample size
The plot_preds function plots the data but doesn't actually return anything
tianyizheng02
force-pushed
the
fix-mypy-errs-1
branch
from
f582de9
to
3b24dfe
Compare
algorithms-keeper
bot
removed
the
tests are failing
|
@cclauss what do you think? |
|
@ChrisO345 mind taking a look? |
ChrisO345
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
For
local_weighted_learning.py:mypyerrors related to the file (that I accidentally introduced in Refactorlocal_weighted_learning.pyto usenp.array#8069 💀), related tomypyproduces errors when run on its own #8070Checklist:
Fixes: #{$ISSUE_NO}.