Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor local_weighted_learning.py to use np.array #8069

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Refactor local_weighted_learning.py to use np.array #8069

merged 4 commits into from
Jan 2, 2023

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Jan 2, 2023 •
edited
Loading

Describe your change:

Fixes #7307 by refactoring machine_learning/local_weighted_learning/local_weighted_learning.py to use np.array rather than np.matrix. This should silence silences the pytest warnings about np.matrix being due to be depreciated.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

github-actions and others added 4 commits January 2, 2023 01:57
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Jan 2, 2023
@tianyizheng02
Copy link
Contributor Author

After checking the pytest logs, it appears that this actually does resolve the warning

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jan 2, 2023
@cclauss cclauss merged commit 725731c into TheAlgorithms:master Jan 2, 2023
@tianyizheng02 tianyizheng02 deleted the np-matrix-depreciated branch January 2, 2023 16:33
@tianyizheng02 tianyizheng02 mentioned this pull request Jan 3, 2023
Merged
14 tasks
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@tianyizheng02 @Cjkjvfnby
Refactor local_weighted_learning.py to use np.array (TheAlgorithm…
3e73c87 
…s#8069)

* updating DIRECTORY.md

* Format local_weighted_learning.py doctests for clarity

* Refactor local_weighted_learning.py to use np.array instead of np.mat

The np.matrix class is planned to be eventually depreciated in favor of
np.array, and current use of the class raises warnings in pytest

* Update local_weighted_learning.py documentation

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PYTEST WARNING] Machine learning local weighted learning
2 participants
@tianyizheng02 @cclauss