Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkersExtractor.extract() API should return result file contents as struct #68

Closed
orchetect opened this issue Nov 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@orchetect
Copy link
Contributor

orchetect commented Nov 24, 2023

So consumers of the library don't need to interact with the result json file, the MarkersExtractor.extract() API should return the result file contents as a struct containing the same information.

Referenced from: TheAcharya/MarkerData#16

@orchetect orchetect added the enhancement New feature or request label Nov 24, 2023
@orchetect orchetect self-assigned this Nov 24, 2023
@orchetect orchetect pinned this issue Nov 24, 2023
@orchetect orchetect changed the title MarkersExtractor.extract() API should return done file contents as struct MarkersExtractor.extract() API should return result file contents as struct Nov 24, 2023
@orchetect
Copy link
Contributor Author

orchetect commented Nov 25, 2023

This is done. Will be in 0.2.6.

public func extract() async throws -> ExportResult {

public struct ExportResult: Equatable, Hashable {
/// Export profile used.
public var profile: ExportProfileFormat
/// Output folder path used for the export.
public var exportFolder: URL
/// CSV manifest file path, if applicable to the profile. `nil` if not applicable.
public var csvManifestPath: URL?
/// CSV manifest file path, if applicable to the profile. `nil` if not applicable.
public var jsonManifestPath: URL?
/// MIDI file path, if applicable to the profile. `nil` if not applicable.
public var midiFilePath: URL?

@IAmVigneswaran
Copy link
Contributor

Thank you!

@orchetect orchetect added this to the 0.2.6 milestone Nov 25, 2023
@orchetect orchetect unpinned this issue Nov 25, 2023
@IAmVigneswaran
Copy link
Contributor

Will close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants