Skip to content

refactor: make EquivalencyExpectationBuilder public #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 1 commit into from
Sep 15, 2025
Merged

refactor: make EquivalencyExpectationBuilder public #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Source/aweXpect.Core/Equivalency/EquivalencyExpectationBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ public override string ToString()
return sb.ToString();
}

public override async Task<ConstraintResult> IsMetBy(
object? value,
public override async Task<ConstraintResult> IsMetBy<TValue>(
TValue value,
IEvaluationContext context,
CancellationToken cancellationToken)
{
Expand Down Expand Up @@ -94,7 +94,10 @@ public override void AppendResult(StringBuilder stringBuilder, string? indentati
}
}

internal abstract class EquivalencyExpectationBuilder : ExpectationBuilder
/// <summary>
/// An <see cref="ExpectationBuilder" /> used in equivalency comparison checks.
/// </summary>
public abstract class EquivalencyExpectationBuilder : ExpectationBuilder
{
/// <summary>
/// Appends the expectation of the root node to the <paramref name="stringBuilder" />.
Expand All @@ -105,12 +108,12 @@ public void AppendExpectation(StringBuilder stringBuilder, string? indentation =
/// <summary>
/// Evaluate if the expectations are met by the <paramref name="value" />.
/// </summary>
public abstract Task<ConstraintResult> IsMetBy(
object? value,
public abstract Task<ConstraintResult> IsMetBy<TValue>(
TValue value,
Comment thread
vbreuss marked this conversation as resolved.
IEvaluationContext context,
CancellationToken cancellationToken);

/// <inheritdoc />
/// <inheritdoc cref="ExpectationBuilder.IsMet(Node, EvaluationContext, ITimeSystem, TimeSpan?, CancellationToken)" />
Comment thread
vbreuss marked this conversation as resolved.
internal override Task<ConstraintResult> IsMet(Node rootNode,
EvaluationContext context,
ITimeSystem timeSystem,
Expand Down
7 changes: 7 additions & 0 deletions Tests/aweXpect.Core.Api.Tests/Expected/aweXpect.Core_net8.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,13 @@ namespace aweXpect.Equivalency
{
public static aweXpect.Equivalency.EquivalencyComparisonType DefaultComparisonType(System.Type type) { }
}
public abstract class EquivalencyExpectationBuilder : aweXpect.Core.ExpectationBuilder
{
protected EquivalencyExpectationBuilder() { }
public void AppendExpectation(System.Text.StringBuilder stringBuilder, string? indentation = null) { }
public abstract System.Threading.Tasks.Task<aweXpect.Core.Constraints.ConstraintResult> IsMetBy<TValue>(TValue value, aweXpect.Core.EvaluationContext.IEvaluationContext context, System.Threading.CancellationToken cancellationToken);
public override aweXpect.Core.ExpectationBuilder UpdateContexts(System.Action<aweXpect.Core.ResultContexts> callback) { }
}
public class EquivalencyOptions : aweXpect.Equivalency.EquivalencyTypeOptions, System.IEquatable<aweXpect.Equivalency.EquivalencyOptions>
{
public EquivalencyOptions() { }
Expand Down
7 changes: 7 additions & 0 deletions Tests/aweXpect.Core.Api.Tests/Expected/aweXpect.Core_netstandard2.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,13 @@ namespace aweXpect.Equivalency
{
public static aweXpect.Equivalency.EquivalencyComparisonType DefaultComparisonType(System.Type type) { }
}
public abstract class EquivalencyExpectationBuilder : aweXpect.Core.ExpectationBuilder
{
protected EquivalencyExpectationBuilder() { }
public void AppendExpectation(System.Text.StringBuilder stringBuilder, string? indentation = null) { }
public abstract System.Threading.Tasks.Task<aweXpect.Core.Constraints.ConstraintResult> IsMetBy<TValue>(TValue value, aweXpect.Core.EvaluationContext.IEvaluationContext context, System.Threading.CancellationToken cancellationToken);
public override aweXpect.Core.ExpectationBuilder UpdateContexts(System.Action<aweXpect.Core.ResultContexts> callback) { }
}
public class EquivalencyOptions : aweXpect.Equivalency.EquivalencyTypeOptions, System.IEquatable<aweXpect.Equivalency.EquivalencyOptions>
{
public EquivalencyOptions() { }
Expand Down
Loading