-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strtod #1290
Fix strtod #1290
Conversation
If the buffer only contains zeros, return 0.
Do not use an approximation to do this. Instead check if the result is Inf.
…or computation - part 2
…nd static_cast =D
Really thank for your contribution. |
Yes, looking into it. But honestly I have no idea whats wrong... Valgrind complains about an uninitialized variable of size 4 in StrtodBigInteger. |
BTW could you cancel all the running appveyor builds? |
Some more need to be fixed.
The valgrind error is fixed now (was due to an incorrect offset computation in BigInteger operator<<). |
until I know what the normal-precision algorithm really does...
Thank you for your precious work! |
Fixes #849, #1249, #1251, #1253, #1256, #1259
The issues were mainly because of unsigned integer overflow and boundary cases. Switched to signed integer arithmetic.
To do:
ParseNumber
. (Or simply using int64 instead of int32)