Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing "8847432036854773723683723...3683723456789012E66" in full precision mode asserts with "!Sign()" #1259

Open
StilesCrisis opened this issue May 15, 2018 · 0 comments
Open

Parsing "8847432036854773723683723...3683723456789012E66" in full precision mode asserts with "!Sign()" #1259

StilesCrisis opened this issue May 15, 2018 · 0 comments
Milestone
v1.2 Beta

Comments

@StilesCrisis
Copy link
Contributor

Parsing the following number in full-precision mode leads to an assertion in NextPositiveDouble:

8847432036854773723683723677529854735473725368547554755293372036854685477529752529337203685468547770151233720097201372368547312337203687203685423685123372036872036854737247372368372367752975258547752975254729752547372368737201701512354737837236737247372368772473723683723456789012E66

    RAPIDJSON_ASSERT(!Sign());
StilesCrisis added a commit to StilesCrisis/rapidjson that referenced this issue May 15, 2018
@StilesCrisis
Add test for issue Tencent#1259
5f7430e
@StilesCrisis StilesCrisis mentioned this issue May 15, 2018
Open
StilesCrisis added a commit to StilesCrisis/rapidjson that referenced this issue May 16, 2018
@StilesCrisis
Merge pull request #10 from StilesCrisis/issue-sign-assertion-test
bf5d3f9 
Add test for issue Tencent#1259
@StilesCrisis StilesCrisis changed the title Parsing "8847432036854773723683723..." in full precision mode asserts with "!Sign()" Parsing "8847432036854773723683723...3683723456789012E66" in full precision mode asserts with "!Sign()" May 16, 2018
@abolz abolz mentioned this issue Jun 15, 2018
Merged
@miloyip miloyip added this to the v1.2 Beta milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2 Beta
Development

No branches or pull requests
2 participants
@miloyip @StilesCrisis