Use 64 KiB as the default progressive load interval#8302
Merged
Stypox merged 2 commits intoTeamNewPipe:release/0.23.0from Apr 29, 2022
Merged
Use 64 KiB as the default progressive load interval#8302Stypox merged 2 commits intoTeamNewPipe:release/0.23.0from
Stypox merged 2 commits intoTeamNewPipe:release/0.23.0from
Conversation
Stypox
force-pushed
the
default-progressive-load-interval
branch
from
1712db5 to
f1ffe3c
Compare
triallax
reviewed
Apr 28, 2022
This ensures a small value is used by default, solving buffering issues at the beginning of videos
Stypox
force-pushed
the
default-progressive-load-interval
branch
from
3120c51 to
6a4d832
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR (partially copied from #8288)
Use 64 KiB as the default progressive load interval. This ensures a small value is used by default, solving buffering issues at the beginning of videos.
This should workaround the problems from #8238.
#8238 (comment)
As a theoretical drawback stuttering may occur on very low bandwith connections, but I think this is negligible (also users can change it in the settings).
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
I tested and the setting still works fine. Using 64 KiB actually speeds up loading the video in the emulator.
Due diligence