Set the progressive_load_interval_default_value to 64 KiB#8288
Closed
litetex wants to merge 1 commit intoTeamNewPipe:devfrom
Closed
Set the progressive_load_interval_default_value to 64 KiB#8288litetex wants to merge 1 commit intoTeamNewPipe:devfrom
litetex wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
5 tasks
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
I don't think this PR solves anything, see how NewPipe/app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java Lines 424 to 435 in 9b3e43f |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What is it?
Description of the changes in your PR
Set the progressive_load_interval_default_value to 64 KiB
This should workaround the problems from #8238.
#8238 (comment)
As a theoretical drawback stuttering may occur on very low bandwith connections, but I think this is negligible (also users can change it in the settings).
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence