Workaround: Set recovery before switching player#7668
Merged
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom Jan 19, 2022
Merged
Workaround: Set recovery before switching player#7668XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
Conversation
4 tasks
|
Kudos, SonarCloud Quality Gate passed! |
XiangRongLin
approved these changes
Jan 19, 2022
Collaborator
|
Reminder for @litetex to reopen the issue or create a followup I hate the solution, but like you already mentioned (although in nicer words) the player is a hot pile of 💩 |
2 tasks
2 tasks
|
@litetex Hi, I've found out that the bug still occurs if you're playing a playlist (enqueued videos). Video progress resets when you switch from main to pop-up and an error occurs when you switch back. |
Collaborator
|
New issue plz. |
Closed
5 tasks
This comment was marked as spam.
This comment was marked as spam.
Contributor
You're writing to a merged PR which fixed an issue😑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What is it?
Description of the changes in your PR
Quick and dirty fix for #7427:
Calls
setRecoverybefore switching the player.See also #7427 (comment)
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence