Skip to content

Workaround: Set recovery before switching player#7668

Merged
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
litetex:fix-video-reset-on-player-switch
Jan 19, 2022
Merged

Workaround: Set recovery before switching player#7668
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
litetex:fix-video-reset-on-player-switch

Conversation

@litetex
Copy link
Member

@litetex litetex commented Jan 17, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Quick and dirty fix for #7427:
Calls setRecovery before switching the player.

See also #7427 (comment)

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible player Issues related to any player (main, popup and background) labels Jan 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@XiangRongLin XiangRongLin merged commit d7fbddf into TeamNewPipe:dev Jan 19, 2022
@XiangRongLin
Copy link
Collaborator

Reminder for @litetex to reopen the issue or create a followup


I hate the solution, but like you already mentioned (although in nicer words) the player is a hot pile of 💩

@Dangelman
Copy link

@litetex Hi, I've found out that the bug still occurs if you're playing a playlist (enqueued videos). Video progress resets when you switch from main to pop-up and an error occurs when you switch back.

@opusforlife2
Copy link
Collaborator

New issue plz.

@ghost

This comment was marked as spam.

@tsiflimagas
Copy link
Contributor

What's the progress of the issue

You're writing to a merged PR which fixed an issue😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video progress resets when switching to popup/background and viceversa

5 participants