Skip to content

Workaround: Set recovery before switching player #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiangRongLin merged 1 commit into from
Jan 19, 2022
Merged

Workaround: Set recovery before switching player #7668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,11 @@ private void openBackgroundPlayer(final boolean append) {

toggleFullscreenIfInFullscreenMode();

if (isPlayerAvailable()) {
// FIXME Workaround #7427
player.setRecovery();
}

if (!useExternalAudioPlayer) {
openNormalBackgroundPlayer(append);
} else {
Expand All @@ -1114,6 +1119,9 @@ private void openPopupPlayer(final boolean append) {
// See UI changes while remote playQueue changes
if (!isPlayerAvailable()) {
playerHolder.startService(false, this);
} else {
// FIXME Workaround #7427
player.setRecovery();
}

toggleFullscreenIfInFullscreenMode();
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/org/schabi/newpipe/player/Player.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ public void handleIntent(@NonNull final Intent intent) {
final boolean isMuted = intent.getBooleanExtra(IS_MUTED, isMuted());

/*
* TODO As seen in #7427 this does not work:
* There are 3 situations when playback shouldn't be started from scratch (zero timestamp):
* 1. User pressed on a timestamp link and the same video should be rewound to the timestamp
* 2. User changed a player from, for example. main to popup, or from audio to main, etc
Expand Down