Skip to content

Conversation

@Redirion
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I just took the commit for PR #6524 and applied it as a patch to master.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Redirion Redirion mentioned this pull request Jun 21, 2021
5 tasks
@triallax triallax added bug Issue is related to a bug player Issues related to any player (main, popup and background) ASAP Issue needs to be fixed as soon as possible labels Jun 21, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Jun 22, 2021

Choosing the resolution inside the player is broken on Android 11 in a Pixel emulator. Main and pop-up player are effected

@Redirion
Copy link
Member Author

working for me on my real Android 11 Pixel 4a

@litetex
Copy link
Member

litetex commented Jun 23, 2021

@Redirion
I can't quite figure that PR out:

As stated in #6524:

Fixes Buffering video unrelated to connection #6510 (hopefully)

Fixing a bug when not knowing the cause (as far I didin't find one in #6510, #6524 and here) and just downgrading something without a clear reasons is not understandable for me.
ExoPlayer was upgraded nearly 3 months ago (in #5856) and no one had problems (or very rare) for at least 3 to 4 releases (was released with v0.21.0)

So some questions regarding that PR:

  • How does it fix Buffering video unrelated to connection #6510?
  • Why doesn't e.g. upgrading to a newer ExoPlayer version fixes that?
  • When the problem is caused by the remote side (e.g. YT servers) how does this PR help fixing that?

@Redirion
Copy link
Member Author

Redirion commented Jun 24, 2021

  1. ExoPlayer 2.12 changed alot, it moved from MediaSource to MediaItem. NewPipe still uses MediaSource. So my wild guess was that beginning with 2.12 the since then deprecated MediaSource was somewhat broken but not all devices were affected so it was unnoticed
  2. I tried with Update ExoPlayer to 2.14 #6295 but got negative feedback, so from that point I thought the only way is to find out if downgrading helps
  3. it won't of course fix anything and if it turns out that that is the issue I will happily directly update to ExoPlayer 2.14.1

@litetex
Copy link
Member

litetex commented Jun 24, 2021

Downgrade will very likely not help, as stated in #6510 (comment)

@Redirion Redirion closed this Jun 24, 2021
@Redirion Redirion deleted the exodowngrade2 branch June 24, 2021 21:43
@AudricV AudricV removed the ASAP Issue needs to be fixed as soon as possible label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants