-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Downgrade to ExoPlayer 2.11.8 #6524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Holy poop. I think this is it! I didn't realise this before, but (probably) since the update to 2.12, the player didn't buffer ahead that much (the bright red line wasn't visible or was very short). With 2.11, the difference is clearly visible. The player buffers ahead by a LOT (the bright red line looks like it's buffered ahead at least a minute or more). At least this is how the UI behaves. Whether that clearly loaded buffer is a placebo or there is actually a difference in buffering, I don't know. |
|
Reject modernity, return to old versions... 😭 |
|
This seems to have fixed the issue for me |
|
@Redirion Please target the master branch, allowing us to make another hotifx version |
|
done in #6542 |
|
Isn't there a button to switch branches in the same PR? I'm pretty sure I've seen something like that being used earlier. |
|
Is there any build available for download? |
|
Checks -> Artifacts |
What is it?
Description of the changes in your PR
Well here we go again. Yet another ExoPlayer downgrade to see if that helps with the buffering issues.
I included by accident the changes from #6515, but that shouldn't hurt.
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence