Skip to content

Conversation

@Redirion
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Well here we go again. Yet another ExoPlayer downgrade to see if that helps with the buffering issues.
I included by accident the changes from #6515, but that shouldn't hurt.

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Redirion Redirion added the player Issues related to any player (main, popup and background) label Jun 19, 2021
@opusforlife2
Copy link
Collaborator

Holy poop. I think this is it!

I didn't realise this before, but (probably) since the update to 2.12, the player didn't buffer ahead that much (the bright red line wasn't visible or was very short).

With 2.11, the difference is clearly visible. The player buffers ahead by a LOT (the bright red line looks like it's buffered ahead at least a minute or more).

At least this is how the UI behaves. Whether that clearly loaded buffer is a placebo or there is actually a difference in buffering, I don't know.

@TacoTheDank
Copy link
Member

Reject modernity, return to old versions... 😭

@TobiGr TobiGr added the bug Issue is related to a bug label Jun 19, 2021
@CBSkarmory
Copy link
Contributor

This seems to have fixed the issue for me

@TobiGr
Copy link
Contributor

TobiGr commented Jun 21, 2021

@Redirion Please target the master branch, allowing us to make another hotifx version

@Redirion Redirion mentioned this pull request Jun 21, 2021
5 tasks
@Redirion
Copy link
Member Author

done in #6542

@Redirion Redirion closed this Jun 21, 2021
@opusforlife2
Copy link
Collaborator

Isn't there a button to switch branches in the same PR? I'm pretty sure I've seen something like that being used earlier.

@Redirion Redirion deleted the exomess branch June 24, 2021 21:43
@plusterkopp
Copy link

Is there any build available for download?

@Redirion
Copy link
Member Author

Checks -> Artifacts
But I would not recommend it. This PR does not improve anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buffering video unrelated to connection

6 participants