Skip to content

Conversation

@kapodamy
Copy link
Contributor

@kapodamy kapodamy commented Sep 1, 2019

[ ✔ ] I carefully read the contribution guidelines and agree to them.

This PR fixes various performance issues in Android 9 (Pie):

  • Drop use of thread handler in the MissionAdapter
  • Validate the file before start the download

fixes #2576 and fixes #2560

Also a toast will be displayed after toggle the SAF switch, because the storage APIs implement different URIs. fixup for #2521

kapodamy and others added 3 commits September 1, 2019 18:37
* validate the stored file before start the mission
* add warning on StoredFileHelper.java
* simplify the communication between MissionAdapter and DownloadManagerService.java since shares the same looper
* simplify setVisible() "start/pause all downloads" buttons logic
@TobiGr TobiGr merged commit 1275d9a into TeamNewPipe:dev Sep 9, 2019
This was referenced Sep 12, 2019
@kapodamy kapodamy deleted the android-pie-workarrounds branch October 1, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lag+crash on downloading videos App crashing on downloading 1080 videos simultaneously.

2 participants