Downloads: add switch for saf/legacy file picker #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* creating files though saf * picking folder though saf
* restore permission request popup previously removed in #2486 * use legacy file picker in cases where saf file picker is not available * fix missing file check logic in prepareSelectedDownload method (DownloadDialog.java)
Contributor
|
@kapodamy Thanks! |
This was referenced Aug 15, 2019
theScrabi
previously approved these changes
Aug 15, 2019
Member
|
Worx |
Contributor
Author
|
|
switch for: * Java I/O Api * Storage Access Framework
kapodamy
changed the title
TobiGr
reviewed
Aug 17, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ROMs are not CTS compliant, in these cases the Storage Access Framework is not fully implemented or functional.
This PR checks whatever is SAF available, otherwise, the legacy API (Java I/O) will be used
changes:
fixes #2498 and fixes #2504