-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add support filtering out unwanted log messages #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After filtering out WARNING noise, I noticed that the progress bar wouldn't reach 100% because skipped items don't increment progress. |
Removing "continue" statements on None conditions did not change anything. still not reaching 100%. Something else is wrong. And the progress outcome is different on every run: 71/100, 73/100, 93/100, 96/100 |
glensc
force-pushed
the
logging-filters
branch
from
October 18, 2022 11:37
cb88f78
to
6795d09
Compare
glensc
force-pushed
the
logging-filters
branch
from
October 18, 2022 11:41
6795d09
to
4a96640
Compare
glensc
added
the
docs needed
Changes in this issue/pull request need to be documented
label
Oct 19, 2022
Merging. Leaving documentation for community to pick up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out common noise, that can't do much anyway.
Example: