Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add support filtering out unwanted log messages #1102

Merged
merged 16 commits into from
Oct 19, 2022

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Oct 15, 2022

Filter out common noise, that can't do much anyway.

Example:

logging:
  filter:
    # Filter out all messages with level WARNING
    - level: WARNING
    # Filter out message with level WARNING and containing a text
    - level: WARNING
      message: "not found on Trakt"
    # Filter out these, not checking the level
    - message: "because provider local has no external Id"
    - message: "because provider none has no external Id"
    - message: "Retry using search for specific Plex Episode"

@glensc glensc self-assigned this Oct 15, 2022
@glensc
Copy link
Collaborator Author

glensc commented Oct 15, 2022

After filtering out WARNING noise, I noticed that the progress bar wouldn't reach 100% because skipped items don't increment progress.

@glensc
Copy link
Collaborator Author

glensc commented Oct 15, 2022

Removing "continue" statements on None conditions did not change anything. still not reaching 100%. Something else is wrong. And the progress outcome is different on every run: 71/100, 73/100, 93/100, 96/100

@glensc glensc marked this pull request as draft October 16, 2022 18:29
@glensc glensc marked this pull request as ready for review October 16, 2022 19:31
@glensc glensc added the docs needed Changes in this issue/pull request need to be documented label Oct 19, 2022
@glensc
Copy link
Collaborator Author

glensc commented Oct 19, 2022

Merging. Leaving documentation for community to pick up.

@glensc glensc merged commit 9e3ae4f into Taxel:main Oct 19, 2022
@glensc glensc deleted the logging-filters branch October 19, 2022 13:28
glensc added a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needed Changes in this issue/pull request need to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant