fix(ci): set ai_fallback_model to satisfy pr-reviewer-action v2.1.10 - #4334
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 4, 2026 2:07p.m. | Review ↗ | |
| Shell | Aug 4, 2026 2:07p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
📝 WalkthroughWalkthroughThe PR updates ChangesPR reviewer workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
AI Automated ReviewAnalysis engine: omniroute@http://litellm.ai.svc.cluster.local/v1 (openai) RecommendationApprove. This is a small, well-documented CI workflow fix that bumps Change-by-Change Findings1. Digest bump:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/agent-pr-review.yaml:
- Line 36: Update the configuration using the misospace/pr-reviewer-action
reference so the action’s fallback model is distinct from the primary model and
does not retry the same URL/model combination; preserve the existing LiteLLM
routing configuration while selecting an appropriate alternate fallback model.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f6a93b6-d6ef-46c0-8fd4-c5b8abcb1723
📒 Files selected for processing (1)
.github/workflows/agent-pr-review.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/toolhive(auto-detected)Tanguille/pr-reviewer-action(auto-detected)Tanguille/renovate-presets(auto-detected)Tanguille/litellm-operator(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
…ion v2.1.10 v2.1.10 made ai_fallback_base_url inherit from ai_base_url when unset, then added validation requiring ai_fallback_model whenever ai_fallback_base_url is set (even inherited) — the action now fails before making any model call. litellm's routerSettings.fallbacks already retries omniroute failures internally with qwen-3.6-fast, so the action's own fallback path only fires if that whole chain fails. Point it at qwen-3.6-fast directly (same litellm endpoint, distinct model) rather than duplicating ai_model — a genuine second attempt, not a no-op retry of what just failed.
19e4dce to
aafaa41
Compare
Summary
Supersedes/absorbs #4329 (the Renovate bump to v2.1.10) by also fixing the validation break it introduces.
v2.1.10 changelog: "Make fallback base_url/api_format/api_key inherit from primary" —
ai_fallback_base_urlnow silently inherits fromai_base_urlwhen unset. The same release also validates thatai_fallback_modelis set wheneverai_fallback_base_urlis set (even inherited), and fails before making any model call otherwise.Fix
ai_fallback_model: qwen-3.6-fast— a real, distinct second attempt via the self-hosted model, not a duplicate ofai_model. litellm's ownrouterSettings.fallbacksalready retriesomniroutefailures internally withqwen-3.6-fast, so this action-level fallback only fires if that whole internal chain fails too.Evidence
Run 30878353953 (self-review of the v2.1.10 bump):
ERROR: AI_FALLBACK_MODEL is required when AI_FALLBACK_BASE_URL is set,duration_ms=42— fails before any model call.Test plan
AI_FALLBACK_MODEL is requirederrorSummary by CodeRabbit