fix(ci): restore runner os:admin so talosctl image pull works - #4090
Merged
Conversation
os:operator (#4088) is rejected by the kubernetesTalosAPIAccess allowlist (allowedRoles: os:admin, os:reader), so the runner never gets a valid talosconfig. os:admin is the only allowlisted role that can pull images.
@@ spec.roles.0 @@
# talos.dev/v1alpha1/ServiceAccount/actions-runner-system/cluster-runner
! ± value change
- os:operator
+ os:admin
|
AI Automated ReviewAnalysis engine: qwen-3.6-fast@http://litellm.ai.svc.cluster.local/v1 (openai) Recommendation: Approve This PR correctly restores the Change Analysis
Required Checks
Standards Compliance
Unknowns
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os:operator(#4088) is rejected by the TaloskubernetesTalosAPIAccessallowlist (allowedRoles: [os:admin, os:reader]intalos/patches/controller/kubernetes-talos-api-access.yaml), so the SA controller mints no talosconfig (ErrRolesNotAllowed) and image-pull stays broken.os:adminis the only allowlisted role that can pull images without a machine-config change. Fixes the image-pull failures on #4084/#4085/#4086 and #4073.