fix(ci): grant runner os:operator for talosctl image pull - #4088
Merged
Conversation
os:reader (set in #4063) lacks the ImagePull API; /machine.MachineService/ImagePull requires os:admin or os:operator, so every image-pull run failed with PermissionDenied. os:operator is the minimal role that includes it.
@@ spec.roles.0 @@
# talos.dev/v1alpha1/ServiceAccount/actions-runner-system/cluster-runner
! ± value change
- os:reader
+ os:operator
|
AI Automated ReviewAnalysis engine: qwen-3.6-fast@http://litellm.ai.svc.cluster.local/v1 (openai) Recommendation: Approve This PR correctly upgrades the Talos ServiceAccount role for the Actions Runner from Change-by-Change Findings
Standards Compliance
Must-Check Items
Unknowns or Needs Verification
|
Tanguille
added a commit
that referenced
this pull request
Jul 20, 2026
os:operator (#4088) is rejected by the kubernetesTalosAPIAccess allowlist (allowedRoles: os:admin, os:reader), so the runner never gets a valid talosconfig. os:admin is the only allowlisted role that can pull images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os:reader(set in #4063) lacks the ImagePull API./machine.MachineService/ImagePullrequiresos:adminoros:operator, so every image-pull run has failed withPermissionDenied: not authorized(e.g. #4084).os:operatoris the minimal role that includes ImagePull — restores image pre-pull without re-granting admin.