Skip to content

Permissions in Android Lollipop #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bezmian merged 8 commits into from
Sep 21, 2017
Merged

Permissions in Android Lollipop #78

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03e7cd2
SlideFragmentBuilder now throws Exception when missing necessary prop…
bezmian Feb 3, 2017
0b17c6a
Fix Codacy issues
bezmian Feb 3, 2017
ede70c4
Fix Codacy issues
bezmian Feb 3, 2017
3d1d1fe
Move permissions handling to SlideFragmentBase
bezmian Feb 8, 2017
57886a4
Create behaviours and fragments package
bezmian Feb 10, 2017
cdfb1bf
Fix showing permissions button in Android Lollipop and versions below.
bezmian Feb 10, 2017
758608b
Merge remote-tracking branch 'origin/release/0.0.6' into feature/perm…
bezmian Feb 20, 2017
c8cbb54
Remove unnecessary methods from CustomSlide
bezmian Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/src/main/java/agency/tango/materialintro/CustomSlide.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,14 @@ public boolean canMoveFurther() {
public String cantMoveFurtherErrorMessage() {
return getString(R.string.error_message);
}

@Override
public String[] possiblePermissions() {
return null;

@radzio radzio Feb 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this after merging #75?

}

@Override
public String[] neededPermissions() {
return null;
}
}
13 changes: 13 additions & 0 deletions ...ro-screen/src/main/java/agency/tango/materialintroscreen/fragments/SlideFragmentBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package agency.tango.materialintroscreen.fragments;

import android.content.pm.PackageManager;
import android.os.Build;
import android.support.annotation.ColorRes;
import android.support.v4.app.ActivityCompat;
import android.support.v4.content.ContextCompat;
Expand Down Expand Up @@ -43,6 +44,10 @@ public String[] neededPermissions() {
}

public boolean hasAnyPermissionsToGrant() {
if (!isAndroidVersionSupportingPermissions()) {
return false;
}

boolean hasPermissionToGrant = hasPermissionsToGrant(neededPermissions());
if (!hasPermissionToGrant) {
hasPermissionToGrant = hasPermissionsToGrant(possiblePermissions());
Expand Down Expand Up @@ -86,6 +91,10 @@ public void askForPermissions() {

@SuppressWarnings({"PMD.CollapsibleIfStatements"})
private boolean hasPermissionsToGrant(String[] permissions) {
if (!isAndroidVersionSupportingPermissions()) {
return false;
}

if (permissions != null) {
for (String permission : permissions) {
if (isNotNullOrEmpty(permission)) {
Expand All @@ -106,6 +115,10 @@ private String[] removeEmptyAndNullStrings(final ArrayList<String> permissions)
return list.toArray(new String[list.size()]);
}

private boolean isAndroidVersionSupportingPermissions() {
return Build.VERSION.SDK_INT >= Build.VERSION_CODES.M;
}

public static boolean isNotNullOrEmpty(String string) {

@radzio radzio Feb 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use TextUtils.isEmpty from Android SDK?

return string != null && !string.isEmpty();
}
Expand Down