Skip to content

Add base slide fragment class#75

Merged
radzio merged 6 commits intorelease/0.0.6from
feature/base_slide_fragment_class
Feb 20, 2017
Merged

Add base slide fragment class#75
radzio merged 6 commits intorelease/0.0.6from
feature/base_slide_fragment_class

Conversation

@bezmian
Copy link
Contributor

@bezmian bezmian commented Feb 8, 2017

No description provided.

@bezmian
SlideFragmentBuilder now throws Exception when missing necessary prop…
03e7cd2 
…erties
@bezmian
Fix Codacy issues
0b17c6a 
 * Better class fields managment
 * Better packages naming
@bezmian
Fix Codacy issues
ede70c4 
 * Suppress warnings in classes from other open source projects
 * Suppress warnings for nested condition statements for better readability
@bezmian
Move permissions handling to SlideFragmentBase
3d1d1fe 
 * SlidesAdapter now stores SlideFragmentBase
 * Migrate every method from SlideFragment to SlideFragmentBase
@bezmian bezmian mentioned this pull request Feb 8, 2017
Closed
@bezmian
Create behaviours and fragments package
57886a4 
 * Move proper classes to packages
 * Optimize imports
@bezmian bezmian mentioned this pull request Feb 10, 2017
Closed
radzio
radzio suggested changes Feb 13, 2017
View reviewed changes
app/src/main/java/agency/tango/materialintro/CustomSlide.java Outdated

@Override
public String[] possiblePermissions() {
return null;
Copy link
Contributor

@radzio radzio Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not like null

ihmo possiblePermissions should not be abstract

app/src/main/java/agency/tango/materialintro/CustomSlide.java Outdated

@Override
public String[] neededPermissions() {
return null;
Copy link
Contributor

@radzio radzio Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

...intro-screen/src/main/java/agency/tango/materialintroscreen/fragments/SlideFragmentBase.java Outdated
private static final int PERMISSIONS_REQUEST_CODE = 15621;

@ColorRes
public abstract int backgroundColor();
Copy link
Contributor

@radzio radzio Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to have all this methods to be abstract?

@bezmian
Make SlideFragmentBase methods not abstract
12fc258 
 * Update Readme
 * Update CustomSlide example
 * Add default slide colors
radzio
radzio approved these changes Feb 20, 2017
View reviewed changes
...ro-screen/src/main/java/agency/tango/materialintroscreen/fragments/SlideFragmentBuilder.java
return this;
}

public SlideFragment build() {
Copy link
Contributor

@radzio radzio Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add unit tests for that in future.

@radzio radzio merged commit 69a806f into release/0.0.6 Feb 20, 2017
@radzio radzio mentioned this pull request Feb 20, 2017
Merged
@bezmian bezmian deleted the feature/base_slide_fragment_class branch September 21, 2017 09:45
bliveinhack added a commit to bliveinhack/material-intro-screen that referenced this pull request Dec 6, 2017
@bliveinhack
Squashed commit of the following:
9a38561 
commit a284407
Merge: 33b0c4e 6cae917
Author: Filip Skowron <filip@norvox.pl>
Date:   Thu Sep 21 12:51:46 2017 +0200

    Merge pull request TangoAgency#97 from TangoAgency/feature/set_message_btn_text

    TangoAgency#91 Add MessageButtonClickListener

commit 6cae917
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 12:45:51 2017 +0200

    TangoAgency#91 Fix issue with non working MessageButtonBehaviour in example IntroActivity

commit ab5745a
Merge: 3fd86e3 33b0c4e
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 12:42:36 2017 +0200

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/set_message_btn_text

    # Conflicts:
    #	README.md
    #	app/src/main/java/agency/tango/materialintro/IntroActivity.java
    #	build.gradle
    #	gradle/wrapper/gradle-wrapper.properties
    #	versions.gradle

commit 33b0c4e
Merge: a3245c0 b92da12
Author: Filip Skowron <filip@norvox.pl>
Date:   Thu Sep 21 12:39:52 2017 +0200

    Merge pull request TangoAgency#87 from TangoAgency/feature/update_lint

    Update Android Support Repository versions

commit b92da12
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 12:29:14 2017 +0200

    TangoAgency#87 Second attempt to fix travis builds

commit b915682
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 12:24:46 2017 +0200

    TangoAgency#87 Attempt to fix travis builds

commit c320585
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 12:19:50 2017 +0200

    TangoAgency#87 Update Android support libraries to 26.1.0

commit 67316a4
Merge: b63f8dc a3245c0
Author: bezmian <filip@norvox.pl>
Date:   Thu Sep 21 11:55:29 2017 +0200

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/update_lint

    # Conflicts:
    #	gradle/wrapper/gradle-wrapper.properties

commit a3245c0
Merge: e510ea9 c8cbb54
Author: Filip Skowron <filip@norvox.pl>
Date:   Thu Sep 21 11:53:40 2017 +0200

    Merge pull request TangoAgency#78 from TangoAgency/feature/permissions_android_lollipop

    Permissions in Android Lollipop

commit e510ea9
Merge: db289f7 b6e9565
Author: Filip Skowron <filip@norvox.pl>
Date:   Thu Sep 21 11:14:17 2017 +0200

    Merge pull request TangoAgency#98 from TangoAgency/feature/custom_permission_string

    TangoAgency#62 Add translatable permissions strings for Slides

commit b6e9565
Author: bezmian <filip@norvox.pl>
Date:   Mon Apr 3 14:40:18 2017 +0200

    TangoAgency#62 Add translatable permissions strings for Slides
     * Update README.md
     * Add example to app module

commit b63f8dc
Author: bezmian <filip@norvox.pl>
Date:   Mon Apr 3 11:22:03 2017 +0200

    Update AndroidSupportLibrary version
     * Fix style bug on Android < v21

commit 3fd86e3
Author: bezmian <filip@norvox.pl>
Date:   Thu Mar 30 11:56:45 2017 +0200

    TangoAgency#91 Add MessageButtonClickListener
     * Update Readme
     * Update gradle
     * Update AndroidSupportRepository version

commit 4dda9b9
Author: bezmian <filip@norvox.pl>
Date:   Fri Mar 3 14:06:04 2017 +0100

    Update Android Support Repository versions
     * Update gradle build tools to 2.3
     * Fix Lint errors in App module

commit c8cbb54
Author: bezmian <filip@norvox.pl>
Date:   Mon Feb 20 14:04:48 2017 +0100

    Remove unnecessary methods from CustomSlide
     * Use Android TextUtils

commit db289f7
Author: Filip Skowron <filip@norvox.pl>
Date:   Mon Feb 20 11:29:34 2017 +0100

    Add showing error on failed swipe (TangoAgency#77)

    * Add ISlideErrorHandler
     * Better code formatting

commit 253c7c8
Author: Filip Skowron <filip@norvox.pl>
Date:   Mon Feb 20 11:22:32 2017 +0100

    Update Support Libraries to 25.1.1 (TangoAgency#80)

    * Add ParallaxPercentFrameLayout
     * Add ParallaxPercentRelativeLayout

commit 758608b
Merge: cdfb1bf b22bf75
Author: bezmian <filip@norvox.pl>
Date:   Mon Feb 20 10:45:53 2017 +0100

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/permissions_android_lollipop

    # Conflicts:
    #	README.md
    #	material-intro-screen/src/main/java/agency/tango/materialintroscreen/fragments/SlideFragmentBase.java

commit b22bf75
Author: Filip Skowron <filip@norvox.pl>
Date:   Mon Feb 20 10:29:53 2017 +0100

    Add Jacoco support (TangoAgency#83)

    * buildToolsVersion set to 25.0.2

commit 69a806f
Author: Filip Skowron <filip@norvox.pl>
Date:   Mon Feb 20 10:29:20 2017 +0100

    Add base slide fragment class (TangoAgency#75)

    * SlideFragmentBuilder now throws Exception when missing necessary properties

    * Fix Codacy issues
     * Better class fields managment
     * Better packages naming

    * Fix Codacy issues
     * Suppress warnings in classes from other open source projects
     * Suppress warnings for nested condition statements for better readability

    * Move permissions handling to SlideFragmentBase
     * SlidesAdapter now stores SlideFragmentBase
     * Migrate every method from SlideFragment to SlideFragmentBase

    * Create behaviours and fragments package
     * Move proper classes to packages
     * Optimize imports

    * Make SlideFragmentBase methods not abstract
     * Update Readme
     * Update CustomSlide example
     * Add default slide colors

commit cdfb1bf
Author: bezmian <filip@norvox.pl>
Date:   Fri Feb 10 16:42:08 2017 +0100

    Fix showing permissions button in Android Lollipop and versions below.

commit 57886a4
Author: bezmian <filip@norvox.pl>
Date:   Fri Feb 10 13:30:25 2017 +0100

    Create behaviours and fragments package
     * Move proper classes to packages
     * Optimize imports

commit 3d1d1fe
Author: bezmian <filip@norvox.pl>
Date:   Wed Feb 8 12:56:32 2017 +0100

    Move permissions handling to SlideFragmentBase
     * SlidesAdapter now stores SlideFragmentBase
     * Migrate every method from SlideFragment to SlideFragmentBase

commit ede70c4
Author: bezmian <filip@norvox.pl>
Date:   Fri Feb 3 16:28:55 2017 +0100

    Fix Codacy issues
     * Suppress warnings in classes from other open source projects
     * Suppress warnings for nested condition statements for better readability

commit 0b17c6a
Author: bezmian <filip@norvox.pl>
Date:   Fri Feb 3 16:04:20 2017 +0100

    Fix Codacy issues
     * Better class fields managment
     * Better packages naming

commit 03e7cd2
Author: bezmian <filip@norvox.pl>
Date:   Fri Feb 3 13:33:05 2017 +0100

    SlideFragmentBuilder now throws Exception when missing necessary properties

commit a0bf6a4
Author: Filip Skowron <filip@norvox.pl>
Date:   Fri Feb 3 12:18:35 2017 +0100

    Add annotations (TangoAgency#71)

    * Update gradle version
     * Add proper annotations for Res assets and variables
     * Add @callsuper in needed places

    * Change OnFinish to OnLastSlidePassed
     * Update README.md
     * Rename method in IFinishListener to onFinish

    * Add proper comment to onLastSlidePassed
     * Improve SlideFragmentBuilder scoping access

    * Fix scoping in SlideFragmentBuilder

commit 5dfec3e
Author: Filip Skowron <filip@norvox.pl>
Date:   Fri Feb 3 11:42:01 2017 +0100

    Add prefix mis_ for all attributes from attrs.xml (TangoAgency#73)

    * Add prefix mis_ for all attributes from attrs.xml

    * Update README.md

    * Add mis_ prefix to all xml resources
     * Remove unused layout xml

    * Styles now doesn't have mis prefixes
     * Better styles naming

    * Update style name in README.md

commit b5d0795
Author: Filip Skowron <filip@norvox.pl>
Date:   Fri Feb 3 11:04:21 2017 +0100

    Fix bug when orientation changes, the screen goes transparent (TangoAgency#72)

    * Fix bug when orientation changes screen goes transparent
     * Improve code quality by extracting code to methods

    * Rename method color to getColorFromRes

    * getBackgroundColor and getButtonsColor now returns int instead of Integer

commit 866260d
Merge: 13515a3 01dd51d
Author: bezmian <filip@norvox.pl>
Date:   Tue Jan 31 11:01:11 2017 +0100

    Merge remote-tracking branch 'origin/master' into develop

commit 13515a3
Merge: 6066dd8 bc51c02
Author: Radek Piekarz <radoslaw.piekarz@gmail.com>
Date:   Thu Dec 1 11:07:21 2016 +0100

    Merged branch develop into develop

commit bc51c02
Merge: e5f34ac 970ebc6
Author: Radek Piekarz <radziupiekarz@gmail.com>
Date:   Wed Oct 12 11:27:29 2016 +0200

    Merge pull request TangoAgency#30 from TangoAgency/release/0.0.4

    Release/0.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@radzio radzio radzio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bezmian @radzio