-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array and provider refactor #588
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
# Conflicts: # packages/form-core/src/FieldApi.ts # packages/form-core/src/FormApi.ts # packages/form-core/src/utils.ts # packages/react-form/src/formContext.ts # packages/react-form/src/types.ts # packages/react-form/src/useField.tsx # packages/react-form/src/useForm.tsx # packages/solid-form/src/createForm.tsx # packages/solid-form/src/types.ts
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1e1e48b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 90.73% 91.18% +0.45%
==========================================
Files 29 26 -3
Lines 766 726 -40
Branches 179 172 -7
==========================================
- Hits 695 662 -33
+ Misses 66 59 -7
Partials 5 5 ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/solid-form/src/tests/createField.test.tsx # packages/vue-form/src/tests/useField.test.tsx # packages/vue-form/src/tests/useForm.test.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing the Provider
go!
Co-authored-by: fuko <[email protected]>
# Conflicts: # docs/config.json
a61d721
to
1e1e48b
Compare
This PR aims to fix issues with array usage typings and removes the Provider component.
With this change, an array-based form in React might look like:
TODO List
For
vsIndex
looping API