Initial version of Lit adapter for Tanstack form #577
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## array-and-provider-refactor #577 +/- ##
===============================================================
- Coverage 91.18% 88.84% -2.34%
===============================================================
Files 26 28 +2
Lines 726 807 +81
Branches 172 185 +13
===============================================================
+ Hits 662 717 +55
- Misses 59 83 +24
- Partials 5 7 +2 ☔ View full report in Codecov by Sentry. |
|
@Christian24 I just realized that we don't have a Lit adapter for TanStack Store. Is there any way we could build this and then utilize it inside of Form's Lit adapter? That would fall more in line with other stuff |
There was a problem hiding this comment.
I haven't finished reviewing the PR, but I'm really happy that it exists!
According the the awesome-lit list, the Lit ecosystem doesn't have a lot libraries for forms (I saw only one, but it was last published 2 years ago and has 55 weekly downloads on npm: @vaading/form), so I think the community will find TanStack/form very useful.
Thank you for your work!
Co-authored-by: fuko <[email protected]>
Co-authored-by: fuko <[email protected]>
Co-authored-by: fuko <[email protected]>
I am not sure where it would be needed honestly. Where exactly are you thinking about? |
There was a problem hiding this comment.
Ok, I'm done with reviewing the whole PR. I have never used Lit, but I tested the examples and read some parts of the Lit docs to get a better understanding on how Lit handles component states (ReactiveController API).
Based on my limited knowledge, this PR is a good first implementation of a Lit adapter for TanStack form. I added a few comments, but they are small ones.
That said, I should not approve the PR until the conversations started by @crutchcorn on the bind directive and the Lit adapter for tanstack/store have been resolved.
Fix issue in ControlValueAccessor
# Conflicts: # packages/solid-form/src/tests/createField.test.tsx # packages/vue-form/src/tests/useField.test.tsx # packages/vue-form/src/tests/useForm.test.tsx
# Conflicts: # pnpm-lock.yaml
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a561827. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
I did not close this PR or delete the upstream branch. Instead, I merged this PR: Which this PR was supposed to be based off of. I don't know what's happened - I've pinged GH (thru private channels). In the meantime, I have a backup somewhere, luckily EDIT: I figured out what happened and have fixed the issue manually. GH has been notified. |
# Conflicts: # docs/config.json # examples/react/array/package.json # examples/solid/array/package.json # examples/vue/array/package.json # pnpm-lock.yaml
This closes #498.
This is the first cut.
It has tests, a basic example and the base-lib, there's also Material Web Components example. I added a little QuickStart guide.
Open points:
.field()can be pretty much anything. Upon further investigation, this seems to be an issue with using an array, so maybeDeepKeysor its use is broken? @crutchcorn?