ci: add mypy check #161
Merged
ci: add mypy check #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedpodtrzitko
commented
May 11, 2024
tagstudio/src/core/library.py
Outdated
Comment on lines
286
to
287
| and self.filename.lower() == __value.filename.lower() # type: ignore | ||
| and self.path.lower() == __value.path.lower() # type: ignore |
Contributor
Author
There was a problem hiding this comment.
looking at this, I'm not convinced this has ever worked, because this object looks like it doesnt have .filename nor .path property 🤔
yedpodtrzitko
force-pushed
the
yed/mypy-check
branch
2 times, most recently
from
12056c7 to
ffbb65e
Compare
yedpodtrzitko
force-pushed
the
yed/mypy-check
branch
from
ffbb65e to
8946135
Compare
yedpodtrzitko
force-pushed
the
yed/mypy-check
branch
from
fbb2873 to
a60ceea
Compare
Member
|
I'm ready to pull this if you're all set |
Contributor
Author
|
@CyanVoxel please go ahead, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add another automatic check beside ruff.
For example in #156 it caught all the errors with wrong method names like
isfile()/is_file(), eg. #156 (comment)This might hurt a bit occasionally, because sometime it will give false positives, but generally it should prevent various errors slipping through, and it's super useful when doing bigger refactorings.
The configuration is now set to slightly permissive mode to keep the diff small-ish. When the pipeline will be in place, we can keep making it more strict.