Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GBFS attributes to station information #115

Closed
edwinvandenbelt opened this issue Mar 20, 2020 · 1 comment · Fixed by #130
Closed

Add GBFS attributes to station information #115

edwinvandenbelt opened this issue Mar 20, 2020 · 1 comment · Fixed by #130
Assignees
Labels
change request New feature or request
Milestone

Comments

@edwinvandenbelt
Copy link
Collaborator

edwinvandenbelt commented Mar 20, 2020

We should add these properties to /operator/station results:

- num_bikes_available Yes Non-negative integer Number of bikes available for rental. Number of functional bikes physically at the station. To know if the bikes are available for rental, see is_renting.
- num_bikes_disabled Optional Non-negative integer Number of disabled bikes at the station. Vendors who do not want to publicize the number of disabled bikes or docks in their system can opt to omit station capacity (in station_information), num_bikes_disabled and num_docks_disabled (as of v2.0). If station capacity is published, then broken docks/bikes can be inferred (though not specifically whether the decreased capacity is a broken bike or dock).
- num_docks_available Conditionally required(as of v2.0) Non-negative integer Required except for stations that have unlimited docking capacity (e.g. virtual stations) (as of v2.0). Number of functional docks physically at the station. To know if the docks are accepting bike returns, see is_returning.
- num_docks_disabled Optional Non-negative integer Number of empty but disabled dock points at the station.
- is_installed Yes Boolean Is the station currently on the street?true - Station is installed on the street.false - Station is not installed on the street.
- is_renting Yes Boolean Is the station currently renting bikes?true - Station is renting bikes. Even if the station is empty, if it is set to allow rentals this value should be 1.false - Station is not renting bikes.
- is_returning Yes Boolean Is the station accepting bike returns?true - Station is accepting bike returns. If a station is full but would allow a return if it was not full, then this value should be 1.false - Station is not accepting bike returns.
- last_reported Yes Timestamp The last time this station reported its status.
@edwinvandenbelt edwinvandenbelt added the change request New feature or request label Mar 20, 2020
@edwinvandenbelt edwinvandenbelt added this to the 1.3 milestone Mar 20, 2020
@edwinvandenbelt edwinvandenbelt added WT1 To be discussed at the next meeting and removed WT1 To be discussed at the next meeting labels Mar 31, 2020
@edwinvandenbelt edwinvandenbelt self-assigned this Apr 2, 2020
edwinvandenbelt added a commit to edwinvandenbelt/TOMP-API that referenced this issue Apr 2, 2020
@edwinvandenbelt edwinvandenbelt linked a pull request Apr 2, 2020 that will close this issue
@edwinvandenbelt
Copy link
Collaborator Author

instead of num-bikes-... it's now num-assets-...

stephanroosli added a commit to stephanroosli/TOMP-API that referenced this issue May 13, 2020
* sync with master

* TOMP-WG#59: overlays can now be handled in a composit-leg,
TOMP-WG#63: geojson to communicate the leg (reducing the message length),
TOMP-WG#83: missing available assets in operator information,
TOMP-WG#85 extra condititions for payment (upfront-payment and pay-when-finished) and optional bank account,
TOMP-WG#87: distance or time based scales,
TOMP-WG#89: fare scales,
TOMP-WG#86: missing MP/TO id

* Add files via upload

* Add files via upload

* typos, moved items in journal-entry, added 'amount available' in asset-type (in response to planning), added card-number in 'cards' (planning), available assets

* Add files via upload

* TOMP-WG#96, TOMP-WG#92, TOMP-WG#91, TOMP-WG#89, TOMP-WG#88, TOMP-WG#87, TOMP-WG#86, TOMP-WG#85, TOMP-WG#83, TOMP-WG#63, TOMP-WG#59

* updated also file '1.1.2'

* Update README

* v.1.1.2 - RC

* 1.1.2

* removed contact, added 'additionalProperties' to facilitate custom extensions (that can be added later on in the standard)

* small bug

* Release 1.2

* Add files via upload

* Add files via upload

* presentations/

* Add files via upload

* Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx

* Add files via upload

* Remove old releases

Motivated by issue TOMP-WG#107 to use git features like tags and branches to point to and maintain releases instead of using separate files.

* Replace coordinate with coordinates
Fix issue TOMP-WG#95

* Update README

* Add files via upload

* Add files via upload

* Add files via upload

* Remove "Learning Environment" link

To avoid confusion between TOMP API testing environment and the Data String Learning environment

* TOMP-WG#110 no reference from asset to it's type. Hotfix

* TOMP-WG#112 added geometries to Operator Information (polygon)

* added a sequence diagram

* versioning proposal

* Create example

* Add files via upload

* Delete example

* Add files via upload

* Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx

* Add files via upload

* TOMP-WG#121 the usage of the openAPI inheritance was not correct. When deserializing objects you'll find out this not working.

* TOMP-WG#120 composit-leg should be composite-leg

* Add files via upload

* Add files via upload

Presentation of Mark Cartwright during WG TOMP-WG#22

* Update README

* Add files via upload

* Add files via upload

* Add files via upload

* Remove "Learning Environment" link

To avoid confusion between TOMP API testing environment and the Data String Learning environment

* Create example

* Add files via upload

* Delete example

* Add files via upload

* Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx

* Add files via upload

* Add files via upload

* Add files via upload

Presentation of Mark Cartwright during WG TOMP-WG#22

* corrected the version number

It was 0.3.0, but with patches TOMP-WG#110, TOMP-WG#112 and TOMP-WG#121 it should be 0.3.1 for now

* corrected version number

* Update TOMP-API.yaml

* Update TOMP-API.yaml

* TOMP-WG#115 Add GBFS attributes to station information

* TOMP-WG#119 Adding personal info. All items are covered

* TOMP-WG#131 hotfix for key-value issue

* TOMP-WG#131 hot fix for key-value

* TOMP-WG#93 Trip Execution: ETA is missing

* Breaking issues
TOMP-WG#114 remove asset, is included in typeOfAsset
TOMP-WG#110 consistency in Operator Information

* Revert "TOMP-WG#131 hot fix for key-value"

This reverts commit 0228ab2.

* Revert "TOMP-WG#131 hot fix for key-value"

This reverts commit 0228ab2.

* Hotfix for key-value object, also removed additionalProperties (no added value)

* hotfix for key-value object

* hotfix for keyValue object

* removed additionalProperties (no added value)

* Remark from Roberto.

* Fix coordinate -> coordinates

Changed systemInformation from array to single object

Change openingTimes to returnTimes

Fix condition inheritance
Reference: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/

Remove duplicate customer requirements

Replace kebab-case with camelCase

Add missing TO tags

Remove station_status fields from stationInformation

Remove duplicate area definition, clarify area usage

Remove gender (should be in asset (type) if anywhere)

Fix allOf and oneOf syntax

Use built-in date format

Fix response codes

Alphabetise sections

* Report session TOMP-WG#22

* bikes on station -> assets on station

* Generatable swagger

* last minute hotfix for keyvalue pair

* Release 0.5.0

* Hotfix to remove double description and fix journal-entry parameters to be query parameters

* scenarios for support (TOMP-WG#157)

authored-by: Edwin van den Belt <[email protected]>

* Fix broken link for Swagger docs

* Add files via upload

Glossary for a common MaaS language

* Update README

* Add files via upload

* Created first version of issue templates

I made a first version of two issue templates. These can be improved of course using pull requests.

* Added participant to readme

Co-authored-by: Edwin van den Belt <[email protected]>
Co-authored-by: Edwin van den Belt <[email protected]>
Co-authored-by: bonbakermans <[email protected]>
Co-authored-by: Edwin van den Belt <[email protected]>
Co-authored-by: Robert Baart <[email protected]>
Co-authored-by: JRobertoReyesG <[email protected]>
Co-authored-by: Threore <[email protected]>
Co-authored-by: Robert Baart <[email protected]>
Co-authored-by: Rosco <[email protected]>
Co-authored-by: pimmeh <[email protected]>
Co-authored-by: Christiaan Rakowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant