-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no reference from asset to asset-type. #110
Labels
Milestone
Comments
edwinvandenbelt
added a commit
to edwinvandenbelt/TOMP-API
that referenced
this issue
Mar 20, 2020
edwinvandenbelt
added a commit
that referenced
this issue
Apr 1, 2020
#110 no reference from asset to it's type. Hotfix
edwinvandenbelt
added a commit
to edwinvandenbelt/TOMP-API
that referenced
this issue
Apr 15, 2020
TOMP-WG#114 remove asset, is included in typeOfAsset TOMP-WG#110 consistency in Operator Information
stephanroosli
added a commit
to stephanroosli/TOMP-API
that referenced
this issue
May 13, 2020
* sync with master * TOMP-WG#59: overlays can now be handled in a composit-leg, TOMP-WG#63: geojson to communicate the leg (reducing the message length), TOMP-WG#83: missing available assets in operator information, TOMP-WG#85 extra condititions for payment (upfront-payment and pay-when-finished) and optional bank account, TOMP-WG#87: distance or time based scales, TOMP-WG#89: fare scales, TOMP-WG#86: missing MP/TO id * Add files via upload * Add files via upload * typos, moved items in journal-entry, added 'amount available' in asset-type (in response to planning), added card-number in 'cards' (planning), available assets * Add files via upload * TOMP-WG#96, TOMP-WG#92, TOMP-WG#91, TOMP-WG#89, TOMP-WG#88, TOMP-WG#87, TOMP-WG#86, TOMP-WG#85, TOMP-WG#83, TOMP-WG#63, TOMP-WG#59 * updated also file '1.1.2' * Update README * v.1.1.2 - RC * 1.1.2 * removed contact, added 'additionalProperties' to facilitate custom extensions (that can be added later on in the standard) * small bug * Release 1.2 * Add files via upload * Add files via upload * presentations/ * Add files via upload * Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx * Add files via upload * Remove old releases Motivated by issue TOMP-WG#107 to use git features like tags and branches to point to and maintain releases instead of using separate files. * Replace coordinate with coordinates Fix issue TOMP-WG#95 * Update README * Add files via upload * Add files via upload * Add files via upload * Remove "Learning Environment" link To avoid confusion between TOMP API testing environment and the Data String Learning environment * TOMP-WG#110 no reference from asset to it's type. Hotfix * TOMP-WG#112 added geometries to Operator Information (polygon) * added a sequence diagram * versioning proposal * Create example * Add files via upload * Delete example * Add files via upload * Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx * Add files via upload * TOMP-WG#121 the usage of the openAPI inheritance was not correct. When deserializing objects you'll find out this not working. * TOMP-WG#120 composit-leg should be composite-leg * Add files via upload * Add files via upload Presentation of Mark Cartwright during WG TOMP-WG#22 * Update README * Add files via upload * Add files via upload * Add files via upload * Remove "Learning Environment" link To avoid confusion between TOMP API testing environment and the Data String Learning environment * Create example * Add files via upload * Delete example * Add files via upload * Delete Presentation MaaS congress 2020 Ross, Pim, Bon.pptx * Add files via upload * Add files via upload * Add files via upload Presentation of Mark Cartwright during WG TOMP-WG#22 * corrected the version number It was 0.3.0, but with patches TOMP-WG#110, TOMP-WG#112 and TOMP-WG#121 it should be 0.3.1 for now * corrected version number * Update TOMP-API.yaml * Update TOMP-API.yaml * TOMP-WG#115 Add GBFS attributes to station information * TOMP-WG#119 Adding personal info. All items are covered * TOMP-WG#131 hotfix for key-value issue * TOMP-WG#131 hot fix for key-value * TOMP-WG#93 Trip Execution: ETA is missing * Breaking issues TOMP-WG#114 remove asset, is included in typeOfAsset TOMP-WG#110 consistency in Operator Information * Revert "TOMP-WG#131 hot fix for key-value" This reverts commit 0228ab2. * Revert "TOMP-WG#131 hot fix for key-value" This reverts commit 0228ab2. * Hotfix for key-value object, also removed additionalProperties (no added value) * hotfix for key-value object * hotfix for keyValue object * removed additionalProperties (no added value) * Remark from Roberto. * Fix coordinate -> coordinates Changed systemInformation from array to single object Change openingTimes to returnTimes Fix condition inheritance Reference: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/ Remove duplicate customer requirements Replace kebab-case with camelCase Add missing TO tags Remove station_status fields from stationInformation Remove duplicate area definition, clarify area usage Remove gender (should be in asset (type) if anywhere) Fix allOf and oneOf syntax Use built-in date format Fix response codes Alphabetise sections * Report session TOMP-WG#22 * bikes on station -> assets on station * Generatable swagger * last minute hotfix for keyvalue pair * Release 0.5.0 * Hotfix to remove double description and fix journal-entry parameters to be query parameters * scenarios for support (TOMP-WG#157) authored-by: Edwin van den Belt <[email protected]> * Fix broken link for Swagger docs * Add files via upload Glossary for a common MaaS language * Update README * Add files via upload * Created first version of issue templates I made a first version of two issue templates. These can be improved of course using pull requests. * Added participant to readme Co-authored-by: Edwin van den Belt <[email protected]> Co-authored-by: Edwin van den Belt <[email protected]> Co-authored-by: bonbakermans <[email protected]> Co-authored-by: Edwin van den Belt <[email protected]> Co-authored-by: Robert Baart <[email protected]> Co-authored-by: JRobertoReyesG <[email protected]> Co-authored-by: Threore <[email protected]> Co-authored-by: Robert Baart <[email protected]> Co-authored-by: Rosco <[email protected]> Co-authored-by: pimmeh <[email protected]> Co-authored-by: Christiaan Rakowski <[email protected]>
stephanroosli
added a commit
to stephanroosli/TOMP-API
that referenced
this issue
Jun 30, 2020
* Replace coordinate with coordinates Fix issue TOMP-WG#95 * TOMP-WG#120 composit-leg should be composite-leg * Update TOMP-API.yaml * Update TOMP-API.yaml * Breaking issues TOMP-WG#114 remove asset, is included in typeOfAsset TOMP-WG#110 consistency in Operator Information * hotfix for keyValue object * Fix coordinate -> coordinates Changed systemInformation from array to single object Change openingTimes to returnTimes Fix condition inheritance Reference: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/ Remove duplicate customer requirements Replace kebab-case with camelCase Add missing TO tags Remove station_status fields from stationInformation Remove duplicate area definition, clarify area usage Remove gender (should be in asset (type) if anywhere) Fix allOf and oneOf syntax Use built-in date format Fix response codes Alphabetise sections * Generatable swagger * last minute hotfix for keyvalue pair * Release 0.5.0 * Hotfix to remove double description and fix journal-entry parameters to be query parameters * scenarios for support (TOMP-WG#157) authored-by: Edwin van den Belt <[email protected]> * Fix broken link for Swagger docs * Add files via upload Glossary for a common MaaS language * Update README * Add files via upload * Created first version of issue templates I made a first version of two issue templates. These can be improved of course using pull requests. * Added participant to readme * Update README (TOMP-WG#160) * Update README Added an invite link to Slack so that everyone can join. This also helps in limiting general TOMP issues where information is being asked of us. * Updated readme Updated the readme to a markup formatting and made headings for easier navigation. * Added XXImo Mobility * Add files via upload * Updated issue templates to be more TOMP-specific Made the issue reports more specifically for TOMP. * Updated bugreport to also incorporate changes * updated MP to Mobility-as-a-service Provider * Add files via upload Presentation on goals and activities WT 2 * Add files via upload * Fix validation issues with missing required fields Closes TOMP-WG#174 * Add files via upload * Update added SBB/Movi+ * Add files via upload Co-authored-by: Robert Baart <[email protected]> Co-authored-by: Edwin van den Belt <[email protected]> Co-authored-by: Edwin van den Belt <[email protected]> Co-authored-by: Threore <[email protected]> Co-authored-by: Robert Baart <[email protected]> Co-authored-by: Rosco <[email protected]> Co-authored-by: Bon Bakermans <[email protected]> Co-authored-by: pimmeh <[email protected]> Co-authored-by: Christiaan Rakowski <[email protected]> Co-authored-by: JRobertoReyesG <[email protected]> Co-authored-by: eborremans <[email protected]> Co-authored-by: Brylie Christopher Oxley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Whenever you have an asset, you'll never know the asset-type....
This is used in
/operator/available-assets
/legs/{id}/available-assets
and in
/planning-options/
All should contain (in 1.3) a type-of-asset, not asset. In the type-of-asset there is already a field amount-available. We should add an array with 'instances' or 'assets', containing the physical assets.
[
{
"type-id": "VALUE",
"name": "string",
"asset-class": "BIKE",
"asset-sub-class": "string", .... ,
"amount-available: 1,
"assets": [{
"asset-id": "string", ....
"place": { ... },
}]
}
]
to remove 'asset' from simple-leg and of the result of /operator/available-assets and replace the result of /legs/{id}/available-assets from asset to asset-type, we should wait until 2.0.
A less elegant solution is to add the asset-type object to the asset. This will increase the amount of transported data.
The text was updated successfully, but these errors were encountered: