Skip to content

adding a suffix to jar name #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nthanvi wants to merge 1 commit into from
Closed

adding a suffix to jar name #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion job-server/src/spark.jobserver/io/JobFileDAO.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class JobFileDAO(config: Config) extends JobDAO {
new File(rootDir, createJarName(appName, uploadTime) + ".jar").getAbsolutePath

private def createJarName(appName: String, uploadTime: DateTime): String =
appName + "-" + uploadTime.toString().replace(':', '_')
appName + "_SNAPPY_JOB_SERVER_JAR_" + uploadTime.toString().replace(':', '_')
Copy link
Copy Markdown

@sumwale sumwale Aug 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will need to register these with executors in most case (SnappyExecutor), will it not be better to register these with the name provided here to install-jar and then use replace-jar for subsequent calls? The additional handling of URLs here and in snappydata looks dicey to me.


override def saveJobInfo(jobInfo: JobInfo) {
writeJobInfo(jobsOutputStream, jobInfo)
Expand Down