Closed
Conversation
A suffix is added to jarname so that executors can identify that job server has provided the updated jar file.
This was referenced Jul 22, 2016
|
|
||
| private def createJarName(appName: String, uploadTime: DateTime): String = | ||
| appName + "-" + uploadTime.toString().replace(':', '_') | ||
| appName + "_SNAPPY_JOB_SERVER_JAR_" + uploadTime.toString().replace(':', '_') |
There was a problem hiding this comment.
Since we will need to register these with executors in most case (SnappyExecutor), will it not be better to register these with the name provided here to install-jar and then use replace-jar for subsequent calls? The additional handling of URLs here and in snappydata looks dicey to me.
Author
|
Not Required Now. As using the install jar/replace jar utility for the lead node route as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A suffix is added to jar name so that executors can identify that
job server has provided the updated jar file and the old jarLoader could be replaced with new Jar.
related PR -
#1
TIBCOSoftware/snappy-spark#39
TIBCOSoftware/snappy-store#88
TIBCOSoftware/snappydata#310