Fix incorrect variable length string data type creation #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the method did not account for string length. This change includes a condition to directly return string types without conversion. Additionally, comments were added for clarity on different data type sections.
Changed the condition from checking 'value' to 'name' for strings. Modified the return statement to ensure proper string conversion. This improves readability and aligns with the updated specification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 95.16% 95.17%
=======================================
Files 48 48
Lines 2193 2195 +2
Branches 262 263 +1
=======================================
+ Hits 2087 2089 +2
Misses 81 81
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the method did not account for string length. This change includes a condition to directly return string types without conversion. Additionally, comments were added for clarity on different data type sections.